From 1b54bf3df433517b50ac7c133443f0a4140757c1 Mon Sep 17 00:00:00 2001
From: Nils Christian Ehmke <nie@informatik.uni-kiel.de>
Date: Sat, 31 Jan 2015 19:22:38 +0100
Subject: [PATCH] FB and PMD issues
---
src/main/java/kieker/gui/common/domain/AbstractTrace.java | 2 +-
src/main/java/kieker/gui/common/domain/OperationCall.java | 2 +-
.../importer/stages/AggregatedTraceStatisticsDecorator.java | 2 +-
.../gui/common/model/importer/stages/TraceAggregator.java | 2 +-
src/main/java/kieker/gui/subview/traces/View.java | 4 ++--
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main/java/kieker/gui/common/domain/AbstractTrace.java b/src/main/java/kieker/gui/common/domain/AbstractTrace.java
index 69eed718..8d6efb10 100644
--- a/src/main/java/kieker/gui/common/domain/AbstractTrace.java
+++ b/src/main/java/kieker/gui/common/domain/AbstractTrace.java
@@ -16,7 +16,7 @@
package kieker.gui.common.domain;
-public abstract class AbstractTrace {
+public abstract class AbstractTrace { // NOPMD (abstract class without abstract methods)
private final OperationCall rootOperationCall;
diff --git a/src/main/java/kieker/gui/common/domain/OperationCall.java b/src/main/java/kieker/gui/common/domain/OperationCall.java
index 70d96891..9b8f06cf 100644
--- a/src/main/java/kieker/gui/common/domain/OperationCall.java
+++ b/src/main/java/kieker/gui/common/domain/OperationCall.java
@@ -21,7 +21,7 @@ import java.util.EnumMap;
import java.util.List;
import java.util.Map;
-public final class OperationCall {
+public final class OperationCall { // NOPMD (cyclomatic complexity)
private final Map<StatisticType, Object> statistics = new EnumMap<>(StatisticType.class);
private final List<OperationCall> children = new ArrayList<>();
diff --git a/src/main/java/kieker/gui/common/model/importer/stages/AggregatedTraceStatisticsDecorator.java b/src/main/java/kieker/gui/common/model/importer/stages/AggregatedTraceStatisticsDecorator.java
index bf32b79d..000c601c 100644
--- a/src/main/java/kieker/gui/common/model/importer/stages/AggregatedTraceStatisticsDecorator.java
+++ b/src/main/java/kieker/gui/common/model/importer/stages/AggregatedTraceStatisticsDecorator.java
@@ -47,7 +47,7 @@ public final class AggregatedTraceStatisticsDecorator extends AbstractStage<Aggr
}
}
- private final class TraceDurationVisitor {
+ private static final class TraceDurationVisitor {
private final List<List<Long>> durationsPerEdge = new ArrayList<>();
private int edgeIndex;
diff --git a/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregator.java b/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregator.java
index 253cfe85..f0b442b6 100644
--- a/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregator.java
+++ b/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregator.java
@@ -43,7 +43,7 @@ public final class TraceAggregator extends AbstractStage<Trace, AggregatedTrace>
}
@Override
- public void onTerminating() throws Exception {
+ public void onTerminating() throws Exception { // NOPMD (the throws clause is forced by the framework)
for (final List<Trace> aggregationList : this.aggregationMap.values()) {
final AggregatedTrace aggregatedTrace = new AggregatedTrace(aggregationList);
super.send(aggregatedTrace);
diff --git a/src/main/java/kieker/gui/subview/traces/View.java b/src/main/java/kieker/gui/subview/traces/View.java
index efa96f78..225450a2 100644
--- a/src/main/java/kieker/gui/subview/traces/View.java
+++ b/src/main/java/kieker/gui/subview/traces/View.java
@@ -14,7 +14,7 @@
* limitations under the License.
***************************************************************************/
-package kieker.gui.subview.traces;
+package kieker.gui.subview.traces; // NOPMD (to many imports)
import java.util.List;
import java.util.Observable;
@@ -328,7 +328,7 @@ public final class View implements Observer, ISubView {
}
final String duration = (Long.toString(operationCall.getDuration()) + " " + View.this.model.getShortTimeUnit()).trim();
item.setText(new String[] { operationCall.getContainer(), componentName, operationString, duration,
- String.format("%.1f%%", (float) operationCall.getStatistic(StatisticType.PERCENT)), traceID });
+ String.format("%.1f%%", operationCall.getStatistic(StatisticType.PERCENT)), traceID });
if (operationCall.isFailed()) {
final Color colorRed = Display.getCurrent().getSystemColor(SWT.COLOR_RED);
--
GitLab