From 3d3cf2ddc36a64e49a3b32a48761e0e0666e4833 Mon Sep 17 00:00:00 2001
From: Nils Christian Ehmke <nie@informatik.uni-kiel.de>
Date: Mon, 23 Feb 2015 10:06:23 +0100
Subject: [PATCH] Fixed some CS and PMD issues
---
.../common/domain/AggregatedOperationCall.java | 6 +++---
.../importer/stages/OperationCallExtractor.java | 16 ++++++++++++++++
.../stages/OperationCallHandlerComposite.java | 4 ++--
.../kieker/diagnosis/common/util/Mapper.java | 4 ++--
.../util/OperationSortListener.java | 2 +-
.../calls/util/OperationSortListener.java | 2 +-
6 files changed, 25 insertions(+), 9 deletions(-)
diff --git a/src/main/java/kieker/diagnosis/common/domain/AggregatedOperationCall.java b/src/main/java/kieker/diagnosis/common/domain/AggregatedOperationCall.java
index 16c69b5e..c8140759 100644
--- a/src/main/java/kieker/diagnosis/common/domain/AggregatedOperationCall.java
+++ b/src/main/java/kieker/diagnosis/common/domain/AggregatedOperationCall.java
@@ -42,9 +42,9 @@ public final class AggregatedOperationCall extends AbstractOperationCall<Aggrega
this.setStackSize(call.getStackSize());
}
- public AggregatedOperationCall(final String container, final String component, final String operation, final String failedCause, final long totalDuration,
- final long medianDuration,
- final long minDuration, final long maxDuration, final long meanDuration, final int calls) {
+ public AggregatedOperationCall(final String container, final String component, final String operation, // NOPMD (a long parameter list cannot be avoided)
+ final String failedCause, final long totalDuration, final long medianDuration, final long minDuration, final long maxDuration, final long meanDuration,
+ final int calls) {
super(container, component, operation);
this.totalDuration = totalDuration;
diff --git a/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallExtractor.java b/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallExtractor.java
index b96fa7a1..e4aa3fce 100644
--- a/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallExtractor.java
+++ b/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallExtractor.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.diagnosis.common.model.importer.stages;
import kieker.diagnosis.common.domain.OperationCall;
diff --git a/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallHandlerComposite.java b/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallHandlerComposite.java
index a6372213..73c8226e 100644
--- a/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallHandlerComposite.java
+++ b/src/main/java/kieker/diagnosis/common/model/importer/stages/OperationCallHandlerComposite.java
@@ -43,8 +43,8 @@ public final class OperationCallHandlerComposite extends CompositeStage {
private final CollectorSink<AggregatedOperationCall> aggCallCollector;
private final CollectorSink<AggregatedOperationCall> aggFailedCallCollector;
- public OperationCallHandlerComposite(final List<OperationCall> operationCalls, final List<OperationCall> failedOperationCalls, final List<AggregatedOperationCall> aggOperationCalls,
- final List<AggregatedOperationCall> aggFailedOperationCalls) {
+ public OperationCallHandlerComposite(final List<OperationCall> operationCalls, final List<OperationCall> failedOperationCalls,
+ final List<AggregatedOperationCall> aggOperationCalls, final List<AggregatedOperationCall> aggFailedOperationCalls) {
this.operationCallExtractor = new OperationCallExtractor();
this.callCollector = new CollectorSink<>(operationCalls);
final Distributor<OperationCall> distributor1 = new Distributor<>(new CopyByReferenceStrategy());
diff --git a/src/main/java/kieker/diagnosis/common/util/Mapper.java b/src/main/java/kieker/diagnosis/common/util/Mapper.java
index 588189f5..0f5b5dea 100644
--- a/src/main/java/kieker/diagnosis/common/util/Mapper.java
+++ b/src/main/java/kieker/diagnosis/common/util/Mapper.java
@@ -40,7 +40,7 @@ public final class Mapper<I, O> {
return null;
}
- public class To {
+ public final class To {
private final I key;
@@ -48,7 +48,7 @@ public final class Mapper<I, O> {
this.key = key;
}
- public void to(final O value) {
+ public void to(final O value) { // NOPMD (the method name may be short, but this is acceptable in this case)
Mapper.this.internalMap.put(this.key, value);
}
diff --git a/src/main/java/kieker/diagnosis/subview/aggregatedcalls/util/OperationSortListener.java b/src/main/java/kieker/diagnosis/subview/aggregatedcalls/util/OperationSortListener.java
index 33fb88e4..ff50b2ab 100644
--- a/src/main/java/kieker/diagnosis/subview/aggregatedcalls/util/OperationSortListener.java
+++ b/src/main/java/kieker/diagnosis/subview/aggregatedcalls/util/OperationSortListener.java
@@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
diff --git a/src/main/java/kieker/diagnosis/subview/calls/util/OperationSortListener.java b/src/main/java/kieker/diagnosis/subview/calls/util/OperationSortListener.java
index 9582950c..4ac82c51 100644
--- a/src/main/java/kieker/diagnosis/subview/calls/util/OperationSortListener.java
+++ b/src/main/java/kieker/diagnosis/subview/calls/util/OperationSortListener.java
@@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
--
GitLab