diff --git a/src/main/java/kieker/gui/Main.java b/src/main/java/kieker/gui/Main.java index 3600738d11f59f99d05dba3ab00138a4499681b9..94497cfc00973a90873acefec3724e262ec0de88 100644 --- a/src/main/java/kieker/gui/Main.java +++ b/src/main/java/kieker/gui/Main.java @@ -25,6 +25,8 @@ import kieker.gui.mainview.Controller; */ public final class Main { + private Main() {} + /** * The main method of this application. * diff --git a/src/main/java/kieker/gui/common/domain/Execution.java b/src/main/java/kieker/gui/common/domain/Execution.java index 1fccf080533c69216a184f0c0d2fc4ab98c8b4e6..53a91f10ec079a8f1cd44305e5f78a7e5ec9335a 100644 --- a/src/main/java/kieker/gui/common/domain/Execution.java +++ b/src/main/java/kieker/gui/common/domain/Execution.java @@ -83,9 +83,6 @@ public final class Execution extends AbstractExecution<Execution> { if (this == other) { return true; } - if (other == null) { - return false; - } if (!(other instanceof Execution)) { return false; } diff --git a/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java b/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java index c8235d4b59fa1bdaeef8c035cac9f5864912a12e..c586347f066bf96ac8f67c0a6de4566947ee693e 100644 --- a/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java +++ b/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java @@ -57,7 +57,8 @@ public final class ImportAnalysisConfiguration extends AnalysisConfiguration { final ReadingComposite reader = new ReadingComposite(importDirectory); final MultipleInstanceOfFilter<IMonitoringRecord> typeFilter = new MultipleInstanceOfFilter<>(); final TraceReconstructionComposite traceReconstruction = new TraceReconstructionComposite(this.traces, this.failedTraces, this.failureContainingTraces); - final TraceAggregationComposite traceAggregation = new TraceAggregationComposite(this.aggregatedTraces, this.failedAggregatedTraces, this.failureContainingAggregatedTraces); + final TraceAggregationComposite traceAggregation = new TraceAggregationComposite(this.aggregatedTraces, this.failedAggregatedTraces, + this.failureContainingAggregatedTraces); final CollectorSink<KiekerMetadataRecord> metadataCollector = new CollectorSink<>(this.metadataRecords); diff --git a/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java b/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java index 5bbd3b4fdc2cc4616ebb585ede6f401d468d1c8d..a3c39036b9ac65869033d50db8405a2bf223bc2f 100644 --- a/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java +++ b/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java @@ -44,7 +44,8 @@ public final class TraceAggregationComposite extends Stage { private final CollectorSink<AggregatedExecution> failedTracesCollector; private final CollectorSink<AggregatedExecution> failureContainingTracesCollector; - public TraceAggregationComposite(final List<AggregatedExecution> traces, final List<AggregatedExecution> failedTraces, final List<AggregatedExecution> failureContainingTraces) { + public TraceAggregationComposite(final List<AggregatedExecution> traces, final List<AggregatedExecution> failedTraces, + final List<AggregatedExecution> failureContainingTraces) { this.aggregator = new TraceAggregator(); this.distributor = new Distributor<>(new CopyByReferenceStrategy()); this.failedTraceFilter = new FailedTraceFilter<>(); diff --git a/src/main/java/kieker/gui/mainview/Controller.java b/src/main/java/kieker/gui/mainview/Controller.java index 68fcb5ae926a1f2db3ca0ad10a0995c05a4a9152..7bf21ed6bcfc9962180e1410e0baee9de2bb5176 100644 --- a/src/main/java/kieker/gui/mainview/Controller.java +++ b/src/main/java/kieker/gui/mainview/Controller.java @@ -147,7 +147,8 @@ public final class Controller implements SelectionListener { } public enum SubView { - TRACES_SUB_VIEW, FAILED_TRACES_SUB_VIEW, AGGREGATED_TRACES_SUB_VIEW, NONE, FAILURE_CONTAINING_TRACES_SUB_VIEW, FAILED_AGGREGATED_TRACES_SUB_VIEW, FAILURE_CONTAINING_AGGREGATED_TRACES_SUB_VIEW + TRACES_SUB_VIEW, FAILED_TRACES_SUB_VIEW, AGGREGATED_TRACES_SUB_VIEW, NONE, FAILURE_CONTAINING_TRACES_SUB_VIEW, FAILED_AGGREGATED_TRACES_SUB_VIEW, + FAILURE_CONTAINING_AGGREGATED_TRACES_SUB_VIEW } } diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java b/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java index b6dc46e7927cb6996b889ab0486e16181038b035..bb12509d79ce291b6821914bb7c53b74893990a0 100644 --- a/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java +++ b/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java @@ -29,7 +29,7 @@ import kieker.gui.subview.util.IModel; import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionListener; -public class Controller implements ISubController, SelectionListener { +public final class Controller implements ISubController, SelectionListener { private final ISubView view; private final Model model; diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/View.java b/src/main/java/kieker/gui/subview/aggregatedtraces/View.java index 520c7a7b687edd7f12f59d82e2c746f80d8dc4d6..076d6afa8609445559ab405f2ceba2bc9c846f83 100644 --- a/src/main/java/kieker/gui/subview/aggregatedtraces/View.java +++ b/src/main/java/kieker/gui/subview/aggregatedtraces/View.java @@ -365,10 +365,10 @@ public final class View implements Observer, ISubView { final String totalDuration = (Long.toString(executionEntry.getTotalDuration()) + " " + View.this.model.getShortTimeUnit()).trim(); if (parent != null) { - item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, "", minDuration, avgDuration, maxDuration, totalDuration }); + item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, "", minDuration, avgDuration, maxDuration, totalDuration, }); } else { item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, Integer.toString(executionEntry.getCalls()), minDuration, avgDuration, - maxDuration, totalDuration }); + maxDuration, totalDuration, }); } if (executionEntry.isFailed()) { diff --git a/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java b/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java index c16c195c4c257477b2cb5c1c6172e742575b6396..f4d89ebed673dd74e4e6e59945318246201f2ebd 100644 --- a/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java +++ b/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java @@ -25,11 +25,11 @@ public abstract class AbstractDirectedComparator<T> implements Comparator<T>, Se private int direction; - public int getDirection() { + public final int getDirection() { return this.direction; } - public void setDirection(final int direction) { + public final void setDirection(final int direction) { this.direction = direction; }