From bc1d0334ca507fdd5ac9600cdad29947d2e91a66 Mon Sep 17 00:00:00 2001
From: Nils Christian Ehmke <nie@informatik.uni-kiel.de>
Date: Fri, 30 Jan 2015 09:54:36 +0100
Subject: [PATCH] Checkstyle issues
---
src/main/java/kieker/gui/Main.java | 2 ++
src/main/java/kieker/gui/common/domain/Execution.java | 3 ---
.../common/model/importer/ImportAnalysisConfiguration.java | 3 ++-
.../model/importer/stages/TraceAggregationComposite.java | 3 ++-
src/main/java/kieker/gui/mainview/Controller.java | 3 ++-
.../java/kieker/gui/subview/aggregatedtraces/Controller.java | 2 +-
src/main/java/kieker/gui/subview/aggregatedtraces/View.java | 4 ++--
.../kieker/gui/subview/util/AbstractDirectedComparator.java | 4 ++--
8 files changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/main/java/kieker/gui/Main.java b/src/main/java/kieker/gui/Main.java
index 3600738d..94497cfc 100644
--- a/src/main/java/kieker/gui/Main.java
+++ b/src/main/java/kieker/gui/Main.java
@@ -25,6 +25,8 @@ import kieker.gui.mainview.Controller;
*/
public final class Main {
+ private Main() {}
+
/**
* The main method of this application.
*
diff --git a/src/main/java/kieker/gui/common/domain/Execution.java b/src/main/java/kieker/gui/common/domain/Execution.java
index 1fccf080..53a91f10 100644
--- a/src/main/java/kieker/gui/common/domain/Execution.java
+++ b/src/main/java/kieker/gui/common/domain/Execution.java
@@ -83,9 +83,6 @@ public final class Execution extends AbstractExecution<Execution> {
if (this == other) {
return true;
}
- if (other == null) {
- return false;
- }
if (!(other instanceof Execution)) {
return false;
}
diff --git a/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java b/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java
index c8235d4b..c586347f 100644
--- a/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java
+++ b/src/main/java/kieker/gui/common/model/importer/ImportAnalysisConfiguration.java
@@ -57,7 +57,8 @@ public final class ImportAnalysisConfiguration extends AnalysisConfiguration {
final ReadingComposite reader = new ReadingComposite(importDirectory);
final MultipleInstanceOfFilter<IMonitoringRecord> typeFilter = new MultipleInstanceOfFilter<>();
final TraceReconstructionComposite traceReconstruction = new TraceReconstructionComposite(this.traces, this.failedTraces, this.failureContainingTraces);
- final TraceAggregationComposite traceAggregation = new TraceAggregationComposite(this.aggregatedTraces, this.failedAggregatedTraces, this.failureContainingAggregatedTraces);
+ final TraceAggregationComposite traceAggregation = new TraceAggregationComposite(this.aggregatedTraces, this.failedAggregatedTraces,
+ this.failureContainingAggregatedTraces);
final CollectorSink<KiekerMetadataRecord> metadataCollector = new CollectorSink<>(this.metadataRecords);
diff --git a/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java b/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java
index 5bbd3b4f..a3c39036 100644
--- a/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java
+++ b/src/main/java/kieker/gui/common/model/importer/stages/TraceAggregationComposite.java
@@ -44,7 +44,8 @@ public final class TraceAggregationComposite extends Stage {
private final CollectorSink<AggregatedExecution> failedTracesCollector;
private final CollectorSink<AggregatedExecution> failureContainingTracesCollector;
- public TraceAggregationComposite(final List<AggregatedExecution> traces, final List<AggregatedExecution> failedTraces, final List<AggregatedExecution> failureContainingTraces) {
+ public TraceAggregationComposite(final List<AggregatedExecution> traces, final List<AggregatedExecution> failedTraces,
+ final List<AggregatedExecution> failureContainingTraces) {
this.aggregator = new TraceAggregator();
this.distributor = new Distributor<>(new CopyByReferenceStrategy());
this.failedTraceFilter = new FailedTraceFilter<>();
diff --git a/src/main/java/kieker/gui/mainview/Controller.java b/src/main/java/kieker/gui/mainview/Controller.java
index 68fcb5ae..7bf21ed6 100644
--- a/src/main/java/kieker/gui/mainview/Controller.java
+++ b/src/main/java/kieker/gui/mainview/Controller.java
@@ -147,7 +147,8 @@ public final class Controller implements SelectionListener {
}
public enum SubView {
- TRACES_SUB_VIEW, FAILED_TRACES_SUB_VIEW, AGGREGATED_TRACES_SUB_VIEW, NONE, FAILURE_CONTAINING_TRACES_SUB_VIEW, FAILED_AGGREGATED_TRACES_SUB_VIEW, FAILURE_CONTAINING_AGGREGATED_TRACES_SUB_VIEW
+ TRACES_SUB_VIEW, FAILED_TRACES_SUB_VIEW, AGGREGATED_TRACES_SUB_VIEW, NONE, FAILURE_CONTAINING_TRACES_SUB_VIEW, FAILED_AGGREGATED_TRACES_SUB_VIEW,
+ FAILURE_CONTAINING_AGGREGATED_TRACES_SUB_VIEW
}
}
diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java b/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java
index b6dc46e7..bb12509d 100644
--- a/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java
+++ b/src/main/java/kieker/gui/subview/aggregatedtraces/Controller.java
@@ -29,7 +29,7 @@ import kieker.gui.subview.util.IModel;
import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.events.SelectionListener;
-public class Controller implements ISubController, SelectionListener {
+public final class Controller implements ISubController, SelectionListener {
private final ISubView view;
private final Model model;
diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/View.java b/src/main/java/kieker/gui/subview/aggregatedtraces/View.java
index 520c7a7b..076d6afa 100644
--- a/src/main/java/kieker/gui/subview/aggregatedtraces/View.java
+++ b/src/main/java/kieker/gui/subview/aggregatedtraces/View.java
@@ -365,10 +365,10 @@ public final class View implements Observer, ISubView {
final String totalDuration = (Long.toString(executionEntry.getTotalDuration()) + " " + View.this.model.getShortTimeUnit()).trim();
if (parent != null) {
- item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, "", minDuration, avgDuration, maxDuration, totalDuration });
+ item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, "", minDuration, avgDuration, maxDuration, totalDuration, });
} else {
item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, Integer.toString(executionEntry.getCalls()), minDuration, avgDuration,
- maxDuration, totalDuration });
+ maxDuration, totalDuration, });
}
if (executionEntry.isFailed()) {
diff --git a/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java b/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java
index c16c195c..f4d89ebe 100644
--- a/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java
+++ b/src/main/java/kieker/gui/subview/util/AbstractDirectedComparator.java
@@ -25,11 +25,11 @@ public abstract class AbstractDirectedComparator<T> implements Comparator<T>, Se
private int direction;
- public int getDirection() {
+ public final int getDirection() {
return this.direction;
}
- public void setDirection(final int direction) {
+ public final void setDirection(final int direction) {
this.direction = direction;
}
--
GitLab