From fdba43573ed20b4599e5d2314c9ce8c9bcca6585 Mon Sep 17 00:00:00 2001
From: Nils Christian Ehmke <nie@informatik.uni-kiel.de>
Date: Thu, 29 Jan 2015 15:09:13 +0100
Subject: [PATCH] Checkstyle issues
---
.../gui/common/domain/AbstractExecution.java | 24 +++++++++----------
.../importer/stages/ReadingComposite.java | 16 +++++++++++++
.../stages/TraceReconstructionComposite.java | 16 +++++++++++++
...regatedExecutionAvgDurationComparator.java | 2 +-
.../AggregatedExecutionCallComparator.java | 2 +-
...regatedExecutionMaxDurationComparator.java | 2 +-
...regatedExecutionMinDurationComparator.java | 2 +-
...gatedExecutionTotalDurationComparator.java | 18 +++++++++++++-
.../java/kieker/gui/subview/traces/View.java | 2 +-
.../util/ExecutionDurationComparator.java | 2 +-
.../util/ExecutionTraceIDComparator.java | 2 +-
.../subview/util/AbstractDataModelProxy.java | 16 +++++++++++++
.../util/ExecutionComponentComparator.java | 2 +-
.../util/ExecutionContainerComparator.java | 2 +-
.../util/ExecutionOperationComparator.java | 2 +-
.../java/kieker/gui/subview/util/IModel.java | 16 +++++++++++++
.../ImportAnalysisConfigurationTest.java | 18 +++++++++++++-
.../stages/TraceReconstructorTest.java | 19 +++++++++++++--
18 files changed, 137 insertions(+), 26 deletions(-)
diff --git a/src/main/java/kieker/gui/common/domain/AbstractExecution.java b/src/main/java/kieker/gui/common/domain/AbstractExecution.java
index 5ee4c195..e979d696 100644
--- a/src/main/java/kieker/gui/common/domain/AbstractExecution.java
+++ b/src/main/java/kieker/gui/common/domain/AbstractExecution.java
@@ -35,7 +35,7 @@ public abstract class AbstractExecution<T extends AbstractExecution<T>> {
this.operation = operation;
}
- public int getTraceDepth() {
+ public final int getTraceDepth() {
int traceDepth = this.children.isEmpty() ? 0 : 1;
int maxChildrenTraceDepth = 0;
@@ -47,7 +47,7 @@ public abstract class AbstractExecution<T extends AbstractExecution<T>> {
return traceDepth;
}
- public int getTraceSize() {
+ public final int getTraceSize() {
int traceSize = 1;
for (final T child : this.children) {
@@ -56,11 +56,11 @@ public abstract class AbstractExecution<T extends AbstractExecution<T>> {
return traceSize;
}
- public boolean isFailed() {
+ public final boolean isFailed() {
return (this.failedCause != null);
}
- public boolean containsFailure() {
+ public final boolean containsFailure() {
if (this.isFailed()) {
return true;
}
@@ -74,36 +74,36 @@ public abstract class AbstractExecution<T extends AbstractExecution<T>> {
return false;
}
- public String getFailedCause() {
+ public final String getFailedCause() {
return this.failedCause;
}
- public void setFailedCause(final String failedCause) {
+ public final void setFailedCause(final String failedCause) {
this.failedCause = failedCause;
}
- public String getContainer() {
+ public final String getContainer() {
return this.container;
}
- public String getComponent() {
+ public final String getComponent() {
return this.component;
}
- public String getOperation() {
+ public final String getOperation() {
return this.operation;
}
- public List<T> getChildren() {
+ public final List<T> getChildren() {
return this.children;
}
- public void addExecutionEntry(final T entry) {
+ public final void addExecutionEntry(final T entry) {
this.children.add(entry);
entry.parent = (T) this;
}
- public T getParent() {
+ public final T getParent() {
return this.parent;
}
diff --git a/src/main/java/kieker/gui/common/model/importer/stages/ReadingComposite.java b/src/main/java/kieker/gui/common/model/importer/stages/ReadingComposite.java
index 531506dd..1d7e5ac3 100644
--- a/src/main/java/kieker/gui/common/model/importer/stages/ReadingComposite.java
+++ b/src/main/java/kieker/gui/common/model/importer/stages/ReadingComposite.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.gui.common.model.importer.stages;
import java.io.File;
diff --git a/src/main/java/kieker/gui/common/model/importer/stages/TraceReconstructionComposite.java b/src/main/java/kieker/gui/common/model/importer/stages/TraceReconstructionComposite.java
index 74c61e45..8d3feb55 100644
--- a/src/main/java/kieker/gui/common/model/importer/stages/TraceReconstructionComposite.java
+++ b/src/main/java/kieker/gui/common/model/importer/stages/TraceReconstructionComposite.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.gui.common.model.importer.stages;
import java.util.List;
diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionAvgDurationComparator.java b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionAvgDurationComparator.java
index 78b6cc18..6631d4a2 100644
--- a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionAvgDurationComparator.java
+++ b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionAvgDurationComparator.java
@@ -21,7 +21,7 @@ import kieker.gui.subview.util.AbstractDirectedComparator;
import org.eclipse.swt.SWT;
-public class AggregatedExecutionAvgDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
+public final class AggregatedExecutionAvgDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionCallComparator.java b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionCallComparator.java
index 01cc0c01..03209580 100644
--- a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionCallComparator.java
+++ b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionCallComparator.java
@@ -21,7 +21,7 @@ import kieker.gui.subview.util.AbstractDirectedComparator;
import org.eclipse.swt.SWT;
-public class AggregatedExecutionCallComparator extends AbstractDirectedComparator<AggregatedExecution> {
+public final class AggregatedExecutionCallComparator extends AbstractDirectedComparator<AggregatedExecution> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMaxDurationComparator.java b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMaxDurationComparator.java
index 00c97763..63940321 100644
--- a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMaxDurationComparator.java
+++ b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMaxDurationComparator.java
@@ -21,7 +21,7 @@ import kieker.gui.subview.util.AbstractDirectedComparator;
import org.eclipse.swt.SWT;
-public class AggregatedExecutionMaxDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
+public final class AggregatedExecutionMaxDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMinDurationComparator.java b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMinDurationComparator.java
index c5cdff3b..8b8fb323 100644
--- a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMinDurationComparator.java
+++ b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionMinDurationComparator.java
@@ -21,7 +21,7 @@ import kieker.gui.subview.util.AbstractDirectedComparator;
import org.eclipse.swt.SWT;
-public class AggregatedExecutionMinDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
+public final class AggregatedExecutionMinDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionTotalDurationComparator.java b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionTotalDurationComparator.java
index 11ff7ef3..962d3952 100644
--- a/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionTotalDurationComparator.java
+++ b/src/main/java/kieker/gui/subview/aggregatedtraces/util/AggregatedExecutionTotalDurationComparator.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.gui.subview.aggregatedtraces.util;
import kieker.gui.common.domain.AggregatedExecution;
@@ -5,7 +21,7 @@ import kieker.gui.subview.util.AbstractDirectedComparator;
import org.eclipse.swt.SWT;
-public class AggregatedExecutionTotalDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
+public final class AggregatedExecutionTotalDurationComparator extends AbstractDirectedComparator<AggregatedExecution> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/traces/View.java b/src/main/java/kieker/gui/subview/traces/View.java
index adfd1135..467e713a 100644
--- a/src/main/java/kieker/gui/subview/traces/View.java
+++ b/src/main/java/kieker/gui/subview/traces/View.java
@@ -47,7 +47,7 @@ import org.eclipse.swt.widgets.TreeColumn;
import org.eclipse.swt.widgets.TreeItem;
import org.eclipse.wb.swt.SWTResourceManager;
-public class View implements Observer, ISubView {
+public final class View implements Observer, ISubView {
private final IModel<Execution> model;
private final Model tracesSubViewModel;
diff --git a/src/main/java/kieker/gui/subview/traces/util/ExecutionDurationComparator.java b/src/main/java/kieker/gui/subview/traces/util/ExecutionDurationComparator.java
index 77e5379f..4e7c38b8 100644
--- a/src/main/java/kieker/gui/subview/traces/util/ExecutionDurationComparator.java
+++ b/src/main/java/kieker/gui/subview/traces/util/ExecutionDurationComparator.java
@@ -21,7 +21,7 @@ import kieker.gui.subview.util.AbstractDirectedComparator;
import org.eclipse.swt.SWT;
-public class ExecutionDurationComparator extends AbstractDirectedComparator<Execution> {
+public final class ExecutionDurationComparator extends AbstractDirectedComparator<Execution> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/traces/util/ExecutionTraceIDComparator.java b/src/main/java/kieker/gui/subview/traces/util/ExecutionTraceIDComparator.java
index a8e459f7..21b0e4f3 100644
--- a/src/main/java/kieker/gui/subview/traces/util/ExecutionTraceIDComparator.java
+++ b/src/main/java/kieker/gui/subview/traces/util/ExecutionTraceIDComparator.java
@@ -21,7 +21,7 @@ import kieker.gui.subview.util.AbstractDirectedComparator;
import org.eclipse.swt.SWT;
-public class ExecutionTraceIDComparator extends AbstractDirectedComparator<Execution> {
+public final class ExecutionTraceIDComparator extends AbstractDirectedComparator<Execution> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/util/AbstractDataModelProxy.java b/src/main/java/kieker/gui/subview/util/AbstractDataModelProxy.java
index 3b1d6b26..9f5d96f8 100644
--- a/src/main/java/kieker/gui/subview/util/AbstractDataModelProxy.java
+++ b/src/main/java/kieker/gui/subview/util/AbstractDataModelProxy.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.gui.subview.util;
import java.util.Observable;
diff --git a/src/main/java/kieker/gui/subview/util/ExecutionComponentComparator.java b/src/main/java/kieker/gui/subview/util/ExecutionComponentComparator.java
index 3e84a7de..792298ff 100644
--- a/src/main/java/kieker/gui/subview/util/ExecutionComponentComparator.java
+++ b/src/main/java/kieker/gui/subview/util/ExecutionComponentComparator.java
@@ -20,7 +20,7 @@ import kieker.gui.common.domain.AbstractExecution;
import org.eclipse.swt.SWT;
-public class ExecutionComponentComparator extends AbstractDirectedComparator<AbstractExecution<?>> {
+public final class ExecutionComponentComparator extends AbstractDirectedComparator<AbstractExecution<?>> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/util/ExecutionContainerComparator.java b/src/main/java/kieker/gui/subview/util/ExecutionContainerComparator.java
index 25950ef0..5b03329b 100644
--- a/src/main/java/kieker/gui/subview/util/ExecutionContainerComparator.java
+++ b/src/main/java/kieker/gui/subview/util/ExecutionContainerComparator.java
@@ -20,7 +20,7 @@ import kieker.gui.common.domain.AbstractExecution;
import org.eclipse.swt.SWT;
-public class ExecutionContainerComparator extends AbstractDirectedComparator<AbstractExecution<?>> {
+public final class ExecutionContainerComparator extends AbstractDirectedComparator<AbstractExecution<?>> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/util/ExecutionOperationComparator.java b/src/main/java/kieker/gui/subview/util/ExecutionOperationComparator.java
index 16e039f0..9eee013e 100644
--- a/src/main/java/kieker/gui/subview/util/ExecutionOperationComparator.java
+++ b/src/main/java/kieker/gui/subview/util/ExecutionOperationComparator.java
@@ -20,7 +20,7 @@ import kieker.gui.common.domain.AbstractExecution;
import org.eclipse.swt.SWT;
-public class ExecutionOperationComparator extends AbstractDirectedComparator<AbstractExecution<?>> {
+public final class ExecutionOperationComparator extends AbstractDirectedComparator<AbstractExecution<?>> {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/kieker/gui/subview/util/IModel.java b/src/main/java/kieker/gui/subview/util/IModel.java
index cb4defde..6871dce6 100644
--- a/src/main/java/kieker/gui/subview/util/IModel.java
+++ b/src/main/java/kieker/gui/subview/util/IModel.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.gui.subview.util;
import java.util.List;
diff --git a/src/test/java/kieker/gui/common/model/importer/ImportAnalysisConfigurationTest.java b/src/test/java/kieker/gui/common/model/importer/ImportAnalysisConfigurationTest.java
index b99884f7..4ebaf98e 100644
--- a/src/test/java/kieker/gui/common/model/importer/ImportAnalysisConfigurationTest.java
+++ b/src/test/java/kieker/gui/common/model/importer/ImportAnalysisConfigurationTest.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.gui.common.model.importer;
import static org.hamcrest.Matchers.empty;
@@ -12,7 +28,7 @@ import org.junit.Test;
import teetime.framework.Analysis;
-public class ImportAnalysisConfigurationTest {
+public final class ImportAnalysisConfigurationTest {
@Test
public void exampleLogImportShouldWork() {
diff --git a/src/test/java/kieker/gui/common/model/importer/stages/TraceReconstructorTest.java b/src/test/java/kieker/gui/common/model/importer/stages/TraceReconstructorTest.java
index cd3a13f9..badd659f 100644
--- a/src/test/java/kieker/gui/common/model/importer/stages/TraceReconstructorTest.java
+++ b/src/test/java/kieker/gui/common/model/importer/stages/TraceReconstructorTest.java
@@ -1,3 +1,19 @@
+/***************************************************************************
+ * Copyright 2014 Kieker Project (http://kieker-monitoring.net)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ ***************************************************************************/
+
package kieker.gui.common.model.importer.stages;
import static org.hamcrest.Matchers.hasSize;
@@ -13,7 +29,6 @@ import kieker.common.record.flow.trace.operation.AfterOperationEvent;
import kieker.common.record.flow.trace.operation.AfterOperationFailedEvent;
import kieker.common.record.flow.trace.operation.BeforeOperationEvent;
import kieker.gui.common.domain.Execution;
-import kieker.gui.common.model.importer.stages.TraceReconstructor;
import org.junit.Before;
import org.junit.Test;
@@ -22,7 +37,7 @@ import teetime.framework.pipe.IPipeFactory;
import teetime.framework.pipe.SingleElementPipeFactory;
import teetime.stage.CollectorSink;
-public class TraceReconstructorTest {
+public final class TraceReconstructorTest {
private List<Execution> traceCollectorList;
private TraceReconstructor reconstructorUnderTest;
--
GitLab