From 516916da33f6a7ce6283a3b37d2c3a5b94fa6775 Mon Sep 17 00:00:00 2001
From: Nils Christian Ehmke <nie@informatik.uni-kiel.de>
Date: Thu, 15 Nov 2012 14:23:11 +0100
Subject: [PATCH] Some minor code modifications for quality reasons.
---
.../java/kieker/webgui/domain/Project.java | 14 ++++++++--
.../persistence/impl/FSProjectDAOImpl.java | 4 ---
.../service/impl/util/PluginFinder.java | 28 ++++++++-----------
3 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/Kieker.WebGUI/src/main/java/kieker/webgui/domain/Project.java b/Kieker.WebGUI/src/main/java/kieker/webgui/domain/Project.java
index dd2002f4..7a7ffbcd 100644
--- a/Kieker.WebGUI/src/main/java/kieker/webgui/domain/Project.java
+++ b/Kieker.WebGUI/src/main/java/kieker/webgui/domain/Project.java
@@ -18,6 +18,8 @@ package kieker.webgui.domain;
import kieker.analysis.model.analysisMetaModel.MIProject;
/**
+ * This is a container for an instance of {@link MIProject}. Later it will probably contain more data.
+ *
* @author Nils Christian Ehmke
*/
public class Project {
@@ -26,8 +28,14 @@ public class Project {
private String lastEditor;
private MIProject projectInstance;
- public Project(final MIProject projectInstace) {
- this.projectInstance = projectInstace;
+ /**
+ * Creates a new instance of this class using the given parameters.
+ *
+ * @param projectInstance
+ * The model instance to be stored in this object.
+ */
+ public Project(final MIProject projectInstance) {
+ this.projectInstance = projectInstance;
}
/**
@@ -42,7 +50,7 @@ public class Project {
/**
* Setter for the property {@link Project#projectInstance}.
*
- * @param projectInstace
+ * @param projectInstance
* The new value of the property.
*/
public void setProjectInstance(final MIProject projectInstance) {
diff --git a/Kieker.WebGUI/src/main/java/kieker/webgui/persistence/impl/FSProjectDAOImpl.java b/Kieker.WebGUI/src/main/java/kieker/webgui/persistence/impl/FSProjectDAOImpl.java
index 8869c43d..eb9c9584 100644
--- a/Kieker.WebGUI/src/main/java/kieker/webgui/persistence/impl/FSProjectDAOImpl.java
+++ b/Kieker.WebGUI/src/main/java/kieker/webgui/persistence/impl/FSProjectDAOImpl.java
@@ -79,10 +79,6 @@ public class FSProjectDAOImpl implements IProjectDAO, ReleaseListener {
* The library for kieker which is contained in the war-file as a resource.
*/
private static final String KIEKER_LIB = "kieker-1.6_emf.jar";
- /**
- * This is the buffer (in bytes) used to copy and upload files.
- */
- private static final int BUF_SIZE_BYTES = 1024 * 1024;
private final MIAnalysisMetaModelFactory factory = new MAnalysisMetaModelFactory();
private final Map<CloseableURLClassLoader, WeakReference<Object>> classLoaders = new ConcurrentHashMap<CloseableURLClassLoader, WeakReference<Object>>();
diff --git a/Kieker.WebGUI/src/main/java/kieker/webgui/service/impl/util/PluginFinder.java b/Kieker.WebGUI/src/main/java/kieker/webgui/service/impl/util/PluginFinder.java
index e55f037d..00bf5e9c 100644
--- a/Kieker.WebGUI/src/main/java/kieker/webgui/service/impl/util/PluginFinder.java
+++ b/Kieker.WebGUI/src/main/java/kieker/webgui/service/impl/util/PluginFinder.java
@@ -62,14 +62,12 @@ public final class PluginFinder {
List<Class<AbstractRepository>> result = null;
- if (clazzes != null) {
- result = new ArrayList<Class<AbstractRepository>>();
- for (final Class<?> clazz : clazzes) {
- // This is the cast resulting in an unchecked cast warning.
- if (clazz.isAnnotationPresent(classAndMethodContainer.getRepositoryAnnotationClass())
- && classAndMethodContainer.getAbstractRepositoryClass().isAssignableFrom(clazz)) {
- result.add((Class<AbstractRepository>) clazz);
- }
+ result = new ArrayList<Class<AbstractRepository>>();
+ for (final Class<?> clazz : clazzes) {
+ // This is the cast resulting in an unchecked cast warning.
+ if (clazz.isAnnotationPresent(classAndMethodContainer.getRepositoryAnnotationClass())
+ && classAndMethodContainer.getAbstractRepositoryClass().isAssignableFrom(clazz)) {
+ result.add((Class<AbstractRepository>) clazz);
}
}
@@ -94,14 +92,12 @@ public final class PluginFinder {
final List<Class<?>> clazzes = this.getAllClassesWithinJar(url, classLoader);
List<Class<AbstractPlugin>> result = null;
- if (clazzes != null) {
- result = new ArrayList<Class<AbstractPlugin>>();
- for (final Class<?> clazz : clazzes) {
- // This is the cast resulting in an unchecked cast warning.
- if (clazz.isAnnotationPresent(classAndMethodContainer.getPluginAnnotationClass())
- && classAndMethodContainer.getAbstractPluginClass().isAssignableFrom(clazz)) {
- result.add((Class<AbstractPlugin>) clazz);
- }
+ result = new ArrayList<Class<AbstractPlugin>>();
+ for (final Class<?> clazz : clazzes) {
+ // This is the cast resulting in an unchecked cast warning.
+ if (clazz.isAnnotationPresent(classAndMethodContainer.getPluginAnnotationClass())
+ && classAndMethodContainer.getAbstractPluginClass().isAssignableFrom(clazz)) {
+ result.add((Class<AbstractPlugin>) clazz);
}
}
--
GitLab