diff --git a/src/main/java/teetime/stage/io/AbstractTcpReader.java b/src/main/java/teetime/stage/io/AbstractTcpReader.java index c7b4e372b0b034533028e87bfde6def32da2951e..5df93077510670c9ddbcd1efd93af6cb70ffdcd4 100644 --- a/src/main/java/teetime/stage/io/AbstractTcpReader.java +++ b/src/main/java/teetime/stage/io/AbstractTcpReader.java @@ -38,13 +38,13 @@ public abstract class AbstractTcpReader<T> extends AbstractProducerStage<T> { socketChannel.close(); } } catch (final IOException ex) { - logger.error("Error while reading", ex); + logger.error("Error while reading.", ex); } finally { if (null != serversocket) { try { serversocket.close(); } catch (final IOException e) { - logger.debug("Failed to close TCP connection!", e); + logger.debug("Failed to close TCP connection.", e); } } @@ -66,6 +66,12 @@ public abstract class AbstractTcpReader<T> extends AbstractProducerStage<T> { } } + /** + * Important note: Do not catch {@link BufferUnderflowException}s since they are caught by the caller to automatically fill the buffer with new content. + * + * @param buffer + * to be read from + */ protected abstract void read(final ByteBuffer buffer); } diff --git a/src/site/markdown/wiki b/src/site/markdown/wiki index cdfd44ee829e7bba079ee71983e5711a4e6cb259..0e4474577e1f49bc96e734c286b2d9e0363895e8 160000 --- a/src/site/markdown/wiki +++ b/src/site/markdown/wiki @@ -1 +1 @@ -Subproject commit cdfd44ee829e7bba079ee71983e5711a4e6cb259 +Subproject commit 0e4474577e1f49bc96e734c286b2d9e0363895e8