From 5e8352ea0916094e39cfbe791aca0eeb85d96659 Mon Sep 17 00:00:00 2001
From: Nelson Tavares de Sousa <stu103017@mail.uni-kiel.de>
Date: Wed, 10 Jun 2015 16:00:46 +0200
Subject: [PATCH] moved from LinkedLists to HashSets
---
src/main/java/teetime/framework/Analysis.java | 6 +++---
.../teetime/framework/AnalysisConfiguration.java | 12 ++++++------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/main/java/teetime/framework/Analysis.java b/src/main/java/teetime/framework/Analysis.java
index 35674e8a..4812ea1f 100644
--- a/src/main/java/teetime/framework/Analysis.java
+++ b/src/main/java/teetime/framework/Analysis.java
@@ -109,7 +109,7 @@ public final class Analysis<T extends AnalysisConfiguration> implements Uncaught
// BETTER validate concurrently
private void validateStages() {
- final List<Stage> threadableStageJobs = this.configuration.getThreadableStageJobs();
+ final Set<Stage> threadableStageJobs = this.configuration.getThreadableStageJobs();
for (Stage stage : threadableStageJobs) {
// // portConnectionValidator.validate(stage);
// }
@@ -134,7 +134,7 @@ public final class Analysis<T extends AnalysisConfiguration> implements Uncaught
instantiatePipes();
- final List<Stage> threadableStageJobs = this.configuration.getThreadableStageJobs();
+ final Set<Stage> threadableStageJobs = this.configuration.getThreadableStageJobs();
if (threadableStageJobs.isEmpty()) {
throw new IllegalStateException("No stage was added using the addThreadableStage(..) method. Add at least one stage.");
}
@@ -177,7 +177,7 @@ public final class Analysis<T extends AnalysisConfiguration> implements Uncaught
}
private void instantiatePipes() {
- List<Stage> threadableStageJobs = configuration.getThreadableStageJobs();
+ Set<Stage> threadableStageJobs = configuration.getThreadableStageJobs();
for (Connection connection : configuration.getConnections()) {
if (threadableStageJobs.contains(connection.getTargetPort().getOwningStage())) {
if (connection.getCapacity() != 0) {
diff --git a/src/main/java/teetime/framework/AnalysisConfiguration.java b/src/main/java/teetime/framework/AnalysisConfiguration.java
index c32f2a29..99dd093a 100644
--- a/src/main/java/teetime/framework/AnalysisConfiguration.java
+++ b/src/main/java/teetime/framework/AnalysisConfiguration.java
@@ -15,8 +15,8 @@
*/
package teetime.framework;
-import java.util.LinkedList;
-import java.util.List;
+import java.util.HashSet;
+import java.util.Set;
import teetime.framework.pipe.IPipe;
import teetime.framework.pipe.IPipeFactory;
@@ -31,8 +31,8 @@ import teetime.util.Connection;
*/
public abstract class AnalysisConfiguration {
- private final List<Stage> threadableStageJobs = new LinkedList<Stage>();
- private final List<Connection<?>> connections = new LinkedList<Connection<?>>();
+ private final Set<Stage> threadableStageJobs = new HashSet<Stage>();
+ private final Set<Connection<?>> connections = new HashSet<Connection<?>>();
@SuppressWarnings("deprecation")
private static final PipeFactoryRegistry PIPE_FACTORY_REGISTRY = PipeFactoryRegistry.INSTANCE;
@@ -50,7 +50,7 @@ public abstract class AnalysisConfiguration {
*/
private final static IPipeFactory interUnboundedThreadFactory = PIPE_FACTORY_REGISTRY.getPipeFactory(ThreadCommunication.INTER, PipeOrdering.QUEUE_BASED, true);
- List<Stage> getThreadableStageJobs() {
+ Set<Stage> getThreadableStageJobs() {
return this.threadableStageJobs;
}
@@ -180,7 +180,7 @@ public abstract class AnalysisConfiguration {
*
* @return a list of pairs of Out- and InputPorts, which are connected
*/
- protected List<Connection<?>> getConnections() {
+ protected Set<Connection<?>> getConnections() {
return connections;
}
--
GitLab