From 804c354eae3ac74dacbee7e4df5599cc6057a160 Mon Sep 17 00:00:00 2001
From: Christian Wulf <chw@informatik.uni-kiel.de>
Date: Wed, 13 May 2015 14:13:56 +0200
Subject: [PATCH] activated fail on error for findbugs and pmd
---
.settings/edu.umd.cs.findbugs.core.prefs | 6 +++---
conf/quality-config/pmd-ruleset.xml | 2 +-
pom.xml | 20 +++++++++++++++++---
3 files changed, 21 insertions(+), 7 deletions(-)
diff --git a/.settings/edu.umd.cs.findbugs.core.prefs b/.settings/edu.umd.cs.findbugs.core.prefs
index 85f5d547..64554dd5 100644
--- a/.settings/edu.umd.cs.findbugs.core.prefs
+++ b/.settings/edu.umd.cs.findbugs.core.prefs
@@ -1,8 +1,8 @@
#FindBugs User Preferences
-#Wed May 13 07:17:09 CEST 2015
-detector_threshold=3
+#Wed May 13 14:13:30 CEST 2015
+detector_threshold=1
effort=max
excludefilter0=.fbExcludeFilterFile|true
-filter_settings=Low|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false|15
+filter_settings=High|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false|15
filter_settings_neg=NOISE|
run_at_full_build=true
diff --git a/conf/quality-config/pmd-ruleset.xml b/conf/quality-config/pmd-ruleset.xml
index 518eae3d..8846898f 100644
--- a/conf/quality-config/pmd-ruleset.xml
+++ b/conf/quality-config/pmd-ruleset.xml
@@ -51,7 +51,7 @@
<!-- custom adaptations -->
- <rule ref="rulesets/java/basic.xml/EmptyCatchBlock" message="Throw at least an IllegalStateException(e)">
+ <rule ref="rulesets/java/empty.xml/EmptyCatchBlock" message="Throw at least an IllegalStateException(e)">
<priority>1</priority>
</rule>
diff --git a/pom.xml b/pom.xml
index ab94f96d..8a2502c3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -238,9 +238,9 @@
<version>3.0.1</version>
<configuration>
<effort>Max</effort>
- <threshold>Low</threshold>
+ <threshold>High</threshold>
<includeTests>true</includeTests>
- <failOnError>false</failOnError>
+<!-- <failOnError>false</failOnError> -->
<excludeFilterFile>${project.basedir}/conf/quality-config/fb-filter.xml</excludeFilterFile>
</configuration>
<executions>
@@ -251,6 +251,18 @@
</goals>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.12</version>
+ </dependency>
+ <dependency>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-library</artifactId>
+ <version>1.3</version>
+ </dependency>
+ </dependencies>
</plugin>
<!-- PMD -->
@@ -271,9 +283,11 @@
<rulesets>
<ruleset>${project.basedir}/conf/quality-config/pmd-ruleset.xml</ruleset>
</rulesets>
+ <linkXref>true</linkXref>
<includeTests>true</includeTests>
<targetJdk>${java.version}</targetJdk>
- <failOnError>false</failOnError>
+<!-- <failurePriority>1</failurePriority> -->
+ <failOnViolation>true</failOnViolation>
</configuration>
<executions>
<execution>
--
GitLab