From a60eacfd2dff1f284c994e599a5336d1d8b2dcd7 Mon Sep 17 00:00:00 2001 From: Christian Wulf <chw@informatik.uni-kiel.de> Date: Wed, 17 Dec 2014 08:13:59 +0100 Subject: [PATCH] fixed PMD issues --- src/main/java/teetime/framework/Stage.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/main/java/teetime/framework/Stage.java b/src/main/java/teetime/framework/Stage.java index a23ea275..561f7623 100644 --- a/src/main/java/teetime/framework/Stage.java +++ b/src/main/java/teetime/framework/Stage.java @@ -14,7 +14,8 @@ import teetime.framework.validation.InvalidPortConnection; * Represents a minimal Stage, with some pre-defined methods. * Implemented stages need to adapt all abstract methods with own implementations. */ -public abstract class Stage { // NOPMD (should not start with "Abstract") +@SuppressWarnings("PMD.AbstractNaming") +public abstract class Stage { private static final ConcurrentMap<String, Integer> INSTANCES_COUNTER = new ConcurrentHashMap<String, Integer>(); @@ -22,6 +23,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract") /** * A unique logger instance per stage instance */ + @SuppressWarnings("PMD.LoggerIsNotStaticFinal") protected final Logger logger; protected Stage() { @@ -30,9 +32,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract") } /** - * Retrieves the identifier associated with the stage - * - * @return An id as String + * @return an identifier that is unique among all stage instances. It is especially unique among all instances of the same stage type. */ public String getId() { return this.id; @@ -56,6 +56,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract") return newId; } + @SuppressWarnings("PMD.DefaultPackage") static void clearInstanceCounters() { INSTANCES_COUNTER.clear(); } -- GitLab