From af03cd2836b9ac30d9bd8b2de81c0fce52ebded3 Mon Sep 17 00:00:00 2001 From: Nelson Tavares de Sousa <ntd@informatik.uni-kiel.de> Date: Wed, 18 Feb 2015 16:39:41 +0100 Subject: [PATCH] declared all stages as final, where possible --- src/main/java/teetime/stage/ByteArray2String.java | 2 +- src/main/java/teetime/stage/Cache.java | 2 +- src/main/java/teetime/stage/CipherByteArray.java | 2 +- src/main/java/teetime/stage/Clock.java | 2 +- src/main/java/teetime/stage/Counter.java | 2 +- src/main/java/teetime/stage/CountingMapMerger.java | 2 +- src/main/java/teetime/stage/ElementDelayMeasuringStage.java | 2 +- .../java/teetime/stage/ElementThroughputMeasuringStage.java | 2 +- src/main/java/teetime/stage/InitialElementProducer.java | 2 +- src/main/java/teetime/stage/MappingCounter.java | 2 +- src/main/java/teetime/stage/basic/distributor/Distributor.java | 2 +- src/main/java/teetime/stage/io/ByteArrayFileWriter.java | 2 +- src/main/java/teetime/stage/io/Directory2FilesFilter.java | 2 +- src/main/java/teetime/stage/io/File2ByteArray.java | 2 +- src/main/java/teetime/stage/io/File2TextLinesFilter.java | 2 +- src/main/java/teetime/stage/io/Printer.java | 2 +- src/main/java/teetime/stage/string/ToLowerCase.java | 2 +- src/main/java/teetime/stage/string/WordCounter.java | 2 +- src/main/java/teetime/stage/util/CountingMap.java | 2 +- src/main/java/teetime/stage/util/MappingException.java | 2 +- src/main/java/teetime/stage/util/TextLine.java | 2 +- 21 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/main/java/teetime/stage/ByteArray2String.java b/src/main/java/teetime/stage/ByteArray2String.java index 8bd6234c..aa9ca726 100644 --- a/src/main/java/teetime/stage/ByteArray2String.java +++ b/src/main/java/teetime/stage/ByteArray2String.java @@ -20,7 +20,7 @@ import java.nio.charset.Charset; import teetime.framework.AbstractConsumerStage; import teetime.framework.OutputPort; -public class ByteArray2String extends AbstractConsumerStage<byte[]> { +public final class ByteArray2String extends AbstractConsumerStage<byte[]> { private final OutputPort<String> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/Cache.java b/src/main/java/teetime/stage/Cache.java index a3562e52..392fcd79 100644 --- a/src/main/java/teetime/stage/Cache.java +++ b/src/main/java/teetime/stage/Cache.java @@ -23,7 +23,7 @@ import teetime.framework.AbstractConsumerStage; import teetime.framework.OutputPort; import teetime.util.StopWatch; -public class Cache<T> extends AbstractConsumerStage<T> { +public final class Cache<T> extends AbstractConsumerStage<T> { private final OutputPort<T> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/CipherByteArray.java b/src/main/java/teetime/stage/CipherByteArray.java index 1dfaab15..ea8c4fb2 100644 --- a/src/main/java/teetime/stage/CipherByteArray.java +++ b/src/main/java/teetime/stage/CipherByteArray.java @@ -30,7 +30,7 @@ import javax.crypto.spec.SecretKeySpec; import teetime.framework.AbstractConsumerStage; import teetime.framework.OutputPort; -public class CipherByteArray extends AbstractConsumerStage<byte[]> { +public final class CipherByteArray extends AbstractConsumerStage<byte[]> { private final OutputPort<byte[]> outputPort = this.createOutputPort(); private Cipher cipher = null; diff --git a/src/main/java/teetime/stage/Clock.java b/src/main/java/teetime/stage/Clock.java index 502121fb..27d35ab4 100644 --- a/src/main/java/teetime/stage/Clock.java +++ b/src/main/java/teetime/stage/Clock.java @@ -18,7 +18,7 @@ package teetime.stage; import teetime.framework.AbstractProducerStage; import teetime.framework.TerminationStrategy; -public class Clock extends AbstractProducerStage<Long> { +public final class Clock extends AbstractProducerStage<Long> { private boolean initialDelayExceeded = false; diff --git a/src/main/java/teetime/stage/Counter.java b/src/main/java/teetime/stage/Counter.java index bcc54f1c..0808f85c 100644 --- a/src/main/java/teetime/stage/Counter.java +++ b/src/main/java/teetime/stage/Counter.java @@ -18,7 +18,7 @@ package teetime.stage; import teetime.framework.AbstractConsumerStage; import teetime.framework.OutputPort; -public class Counter<T> extends AbstractConsumerStage<T> { +public final class Counter<T> extends AbstractConsumerStage<T> { private final OutputPort<T> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/CountingMapMerger.java b/src/main/java/teetime/stage/CountingMapMerger.java index 1ca07fb2..22a5bb1b 100644 --- a/src/main/java/teetime/stage/CountingMapMerger.java +++ b/src/main/java/teetime/stage/CountingMapMerger.java @@ -34,7 +34,7 @@ import teetime.stage.util.CountingMap; * @param <T> * Key type of the map to be sent */ -public class CountingMapMerger<T> extends AbstractConsumerStage<CountingMap<T>> { +public final class CountingMapMerger<T> extends AbstractConsumerStage<CountingMap<T>> { private final CountingMap<T> result = new CountingMap<T>(); private final OutputPort<Map<T, Integer>> port = createOutputPort(); diff --git a/src/main/java/teetime/stage/ElementDelayMeasuringStage.java b/src/main/java/teetime/stage/ElementDelayMeasuringStage.java index 1769482d..5777aebb 100644 --- a/src/main/java/teetime/stage/ElementDelayMeasuringStage.java +++ b/src/main/java/teetime/stage/ElementDelayMeasuringStage.java @@ -22,7 +22,7 @@ import teetime.framework.AbstractConsumerStage; import teetime.framework.InputPort; import teetime.framework.OutputPort; -public class ElementDelayMeasuringStage<T> extends AbstractConsumerStage<T> { +public final class ElementDelayMeasuringStage<T> extends AbstractConsumerStage<T> { private final InputPort<Long> triggerInputPort = this.createInputPort(); private final OutputPort<T> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/ElementThroughputMeasuringStage.java b/src/main/java/teetime/stage/ElementThroughputMeasuringStage.java index 92394131..a986ed8e 100644 --- a/src/main/java/teetime/stage/ElementThroughputMeasuringStage.java +++ b/src/main/java/teetime/stage/ElementThroughputMeasuringStage.java @@ -23,7 +23,7 @@ import teetime.framework.AbstractConsumerStage; import teetime.framework.InputPort; import teetime.framework.OutputPort; -public class ElementThroughputMeasuringStage<T> extends AbstractConsumerStage<T> { +public final class ElementThroughputMeasuringStage<T> extends AbstractConsumerStage<T> { private final InputPort<Long> triggerInputPort = this.createInputPort(); private final OutputPort<T> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/InitialElementProducer.java b/src/main/java/teetime/stage/InitialElementProducer.java index 4cc17205..733d3be8 100644 --- a/src/main/java/teetime/stage/InitialElementProducer.java +++ b/src/main/java/teetime/stage/InitialElementProducer.java @@ -17,7 +17,7 @@ package teetime.stage; import teetime.framework.AbstractProducerStage; -public class InitialElementProducer<T> extends AbstractProducerStage<T> { +public final class InitialElementProducer<T> extends AbstractProducerStage<T> { private final T[] elements; diff --git a/src/main/java/teetime/stage/MappingCounter.java b/src/main/java/teetime/stage/MappingCounter.java index 5f433696..ee9ab918 100644 --- a/src/main/java/teetime/stage/MappingCounter.java +++ b/src/main/java/teetime/stage/MappingCounter.java @@ -30,7 +30,7 @@ import teetime.stage.util.CountingMap; * @param <T> * Type to be count */ -public class MappingCounter<T> extends AbstractConsumerStage<T> { +public final class MappingCounter<T> extends AbstractConsumerStage<T> { private final CountingMap<T> counter = new CountingMap<T>(); private final OutputPort<CountingMap<T>> port = createOutputPort(); diff --git a/src/main/java/teetime/stage/basic/distributor/Distributor.java b/src/main/java/teetime/stage/basic/distributor/Distributor.java index e591cfd2..ac5f845a 100644 --- a/src/main/java/teetime/stage/basic/distributor/Distributor.java +++ b/src/main/java/teetime/stage/basic/distributor/Distributor.java @@ -26,7 +26,7 @@ import teetime.framework.OutputPort; * @param T * the type of the input port and the output ports */ -public class Distributor<T> extends AbstractConsumerStage<T> { +public final class Distributor<T> extends AbstractConsumerStage<T> { private IDistributorStrategy strategy; diff --git a/src/main/java/teetime/stage/io/ByteArrayFileWriter.java b/src/main/java/teetime/stage/io/ByteArrayFileWriter.java index b7a3d048..66bb89cb 100644 --- a/src/main/java/teetime/stage/io/ByteArrayFileWriter.java +++ b/src/main/java/teetime/stage/io/ByteArrayFileWriter.java @@ -23,7 +23,7 @@ import teetime.framework.AbstractConsumerStage; import com.google.common.io.Files; -public class ByteArrayFileWriter extends AbstractConsumerStage<byte[]> { +public final class ByteArrayFileWriter extends AbstractConsumerStage<byte[]> { private final File file; private FileOutputStream fo; diff --git a/src/main/java/teetime/stage/io/Directory2FilesFilter.java b/src/main/java/teetime/stage/io/Directory2FilesFilter.java index 4833b3ec..c306b236 100644 --- a/src/main/java/teetime/stage/io/Directory2FilesFilter.java +++ b/src/main/java/teetime/stage/io/Directory2FilesFilter.java @@ -28,7 +28,7 @@ import teetime.framework.OutputPort; * * @since 1.10 */ -public class Directory2FilesFilter extends AbstractConsumerStage<File> { +public final class Directory2FilesFilter extends AbstractConsumerStage<File> { private final OutputPort<File> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/io/File2ByteArray.java b/src/main/java/teetime/stage/io/File2ByteArray.java index 30d0b757..155a45a3 100644 --- a/src/main/java/teetime/stage/io/File2ByteArray.java +++ b/src/main/java/teetime/stage/io/File2ByteArray.java @@ -23,7 +23,7 @@ import teetime.framework.OutputPort; import com.google.common.io.Files; -public class File2ByteArray extends AbstractConsumerStage<File> { +public final class File2ByteArray extends AbstractConsumerStage<File> { private final OutputPort<byte[]> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/io/File2TextLinesFilter.java b/src/main/java/teetime/stage/io/File2TextLinesFilter.java index 609232d9..977fef59 100644 --- a/src/main/java/teetime/stage/io/File2TextLinesFilter.java +++ b/src/main/java/teetime/stage/io/File2TextLinesFilter.java @@ -30,7 +30,7 @@ import teetime.stage.util.TextLine; * @author Christian Wulf * */ -public class File2TextLinesFilter extends AbstractConsumerStage<File> { +public final class File2TextLinesFilter extends AbstractConsumerStage<File> { private final OutputPort<TextLine> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/io/Printer.java b/src/main/java/teetime/stage/io/Printer.java index 3aacc3b0..bd369831 100644 --- a/src/main/java/teetime/stage/io/Printer.java +++ b/src/main/java/teetime/stage/io/Printer.java @@ -29,7 +29,7 @@ import teetime.framework.AbstractConsumerStage; * * @since 1.10 */ -public class Printer<T> extends AbstractConsumerStage<T> { +public final class Printer<T> extends AbstractConsumerStage<T> { public static final String STREAM_STDOUT = "STDOUT"; public static final String STREAM_STDERR = "STDERR"; diff --git a/src/main/java/teetime/stage/string/ToLowerCase.java b/src/main/java/teetime/stage/string/ToLowerCase.java index 9841dbc1..ee32c2bd 100644 --- a/src/main/java/teetime/stage/string/ToLowerCase.java +++ b/src/main/java/teetime/stage/string/ToLowerCase.java @@ -27,7 +27,7 @@ import teetime.framework.OutputPort; * @author Nelson Tavares de Sousa * */ -public class ToLowerCase extends AbstractConsumerStage<String> { +public final class ToLowerCase extends AbstractConsumerStage<String> { private final OutputPort<String> outputPort = this.createOutputPort(); diff --git a/src/main/java/teetime/stage/string/WordCounter.java b/src/main/java/teetime/stage/string/WordCounter.java index 0266f044..9f26beee 100644 --- a/src/main/java/teetime/stage/string/WordCounter.java +++ b/src/main/java/teetime/stage/string/WordCounter.java @@ -34,7 +34,7 @@ import teetime.stage.util.CountingMap; * @author Nelson Tavares de Sousa * */ -public class WordCounter extends CompositeStage { +public final class WordCounter extends CompositeStage { // This fields are needed for the methods to work. private final Tokenizer tokenizer = new Tokenizer(" "); diff --git a/src/main/java/teetime/stage/util/CountingMap.java b/src/main/java/teetime/stage/util/CountingMap.java index 1c995c28..e468acac 100644 --- a/src/main/java/teetime/stage/util/CountingMap.java +++ b/src/main/java/teetime/stage/util/CountingMap.java @@ -28,7 +28,7 @@ import java.util.HashMap; * @param <T> * Key type to be count */ -public class CountingMap<T> extends HashMap<T, Integer> { +public final class CountingMap<T> extends HashMap<T, Integer> { /** * Generated serialVersionUID diff --git a/src/main/java/teetime/stage/util/MappingException.java b/src/main/java/teetime/stage/util/MappingException.java index 8761af48..456b6191 100644 --- a/src/main/java/teetime/stage/util/MappingException.java +++ b/src/main/java/teetime/stage/util/MappingException.java @@ -20,7 +20,7 @@ package teetime.stage.util; * * @since 1.10 */ -public class MappingException extends Exception { +public final class MappingException extends Exception { private static final long serialVersionUID = 7300752837946139350L; diff --git a/src/main/java/teetime/stage/util/TextLine.java b/src/main/java/teetime/stage/util/TextLine.java index e9ddbd6f..ecbfdb32 100644 --- a/src/main/java/teetime/stage/util/TextLine.java +++ b/src/main/java/teetime/stage/util/TextLine.java @@ -22,7 +22,7 @@ import java.io.File; * * @since 1.10 */ -public class TextLine { +public final class TextLine { private final File textFile; private final String textLine; -- GitLab