From b65b71f6691fe8200c6b4cb47c0f4458580ad354 Mon Sep 17 00:00:00 2001
From: Nelson Tavares de Sousa <ntd@informatik.uni-kiel.de>
Date: Fri, 7 Nov 2014 14:26:29 +0100
Subject: [PATCH] utility classes changed to final marked error in CRAQ as
seen, because this will never cause an error
---
src/main/java/teetime/framework/pipe/PipeFactoryLoader.java | 2 +-
src/main/java/teetime/util/ListUtil.java | 2 +-
src/main/java/teetime/util/MathUtil.java | 4 ++--
.../teetime/util/list/CommittableResizableArrayQueue.java | 6 +++---
4 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/main/java/teetime/framework/pipe/PipeFactoryLoader.java b/src/main/java/teetime/framework/pipe/PipeFactoryLoader.java
index 2e129e2f..12799988 100644
--- a/src/main/java/teetime/framework/pipe/PipeFactoryLoader.java
+++ b/src/main/java/teetime/framework/pipe/PipeFactoryLoader.java
@@ -14,7 +14,7 @@ import org.slf4j.LoggerFactory;
import teetime.framework.FileSearcher;
-public class PipeFactoryLoader {
+public final class PipeFactoryLoader {
private static final Logger LOGGER = LoggerFactory.getLogger(PipeFactoryLoader.class);
diff --git a/src/main/java/teetime/util/ListUtil.java b/src/main/java/teetime/util/ListUtil.java
index bea4f12e..cd6ca171 100644
--- a/src/main/java/teetime/util/ListUtil.java
+++ b/src/main/java/teetime/util/ListUtil.java
@@ -3,7 +3,7 @@ package teetime.util;
import java.util.Collection;
import java.util.List;
-public class ListUtil {
+public final class ListUtil {
private ListUtil() {
// utility class
diff --git a/src/main/java/teetime/util/MathUtil.java b/src/main/java/teetime/util/MathUtil.java
index 71a36bc0..bfd90bb2 100644
--- a/src/main/java/teetime/util/MathUtil.java
+++ b/src/main/java/teetime/util/MathUtil.java
@@ -19,10 +19,10 @@ import java.util.List;
/**
* @author Christian Wulf
- *
+ *
* @since 1.10
*/
-public class MathUtil {
+public final class MathUtil {
private MathUtil() {
// utility class
diff --git a/src/main/java/teetime/util/list/CommittableResizableArrayQueue.java b/src/main/java/teetime/util/list/CommittableResizableArrayQueue.java
index 6a6b2afe..d8929c3e 100644
--- a/src/main/java/teetime/util/list/CommittableResizableArrayQueue.java
+++ b/src/main/java/teetime/util/list/CommittableResizableArrayQueue.java
@@ -2,7 +2,7 @@ package teetime.util.list;
public class CommittableResizableArrayQueue<T> implements CommittableQueue<T> {
- private final int MIN_CAPACITY;
+ // private final int MIN_CAPACITY;
private final ArrayPool<T> arrayPool;
private T[] elements;
@@ -13,11 +13,11 @@ public class CommittableResizableArrayQueue<T> implements CommittableQueue<T> {
public CommittableResizableArrayQueue(final Object emptyObject, final int initialCapacity) {
super();
this.arrayPool = new ArrayPool<T>();
- this.MIN_CAPACITY = initialCapacity + 1;
+ // this.MIN_CAPACITY = initialCapacity + 1;
this.elements = this.arrayPool.acquire(initialCapacity + 1);
this.elements[0] = (T) emptyObject; // optimization: avoids the use of an index out-of-bounds check
- this.clear();
+ this.clear(); // NOPMD
}
@Override
--
GitLab