From f25c732e68cf7963b69538f04e6fcad71a741eee Mon Sep 17 00:00:00 2001
From: Christian Wulf <chw@informatik.uni-kiel.de>
Date: Tue, 21 Apr 2015 14:26:10 +0200
Subject: [PATCH] fixed some pmd issues

---
 conf/quality-config/pmd-ruleset.xml                  | 1 +
 src/main/java/teetime/stage/FileExtensionSwitch.java | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/conf/quality-config/pmd-ruleset.xml b/conf/quality-config/pmd-ruleset.xml
index 012fa89c..d1ae4b3e 100644
--- a/conf/quality-config/pmd-ruleset.xml
+++ b/conf/quality-config/pmd-ruleset.xml
@@ -78,6 +78,7 @@
 
 	<rule ref="rulesets/java/optimizations.xml">
 		<exclude name="LocalVariableCouldBeFinal" />
+		<exclude name="SimplifyStartsWith" />
 	</rule>
 
 
diff --git a/src/main/java/teetime/stage/FileExtensionSwitch.java b/src/main/java/teetime/stage/FileExtensionSwitch.java
index 7b39f3f9..4fc98edf 100644
--- a/src/main/java/teetime/stage/FileExtensionSwitch.java
+++ b/src/main/java/teetime/stage/FileExtensionSwitch.java
@@ -27,7 +27,7 @@ import com.google.common.io.Files;
 
 public final class FileExtensionSwitch extends AbstractConsumerStage<File> {
 
-	private final OutputPort<File> unknownFileExtensionOutputPort = createOutputPort();
+	private final OutputPort<File> unknownFileExtensionOutputPort = createOutputPort(File.class);
 
 	// BETTER use the hppc ObjectObjectMap that provide getOrDefault()
 	private final Map<String, OutputPort<File>> fileExtensions = new HashMapWithDefault<String, OutputPort<File>>(new ValueFactory<OutputPort<File>>() {
@@ -48,6 +48,7 @@ public final class FileExtensionSwitch extends AbstractConsumerStage<File> {
 		outputPort.send(file);
 	}
 
+	@SuppressWarnings("PMD.AvoidReassigningParameters")
 	public OutputPort<File> addFileExtension(String fileExtension) {
 		if (fileExtension.startsWith(".")) {
 			fileExtension = fileExtension.substring(1);
-- 
GitLab