diff --git a/src/main/java/teetime/framework/AbstractInterThreadPipe.java b/src/main/java/teetime/framework/AbstractInterThreadPipe.java index 5471576ba9def3c1a59caa923df4237d2495559b..9821a41bbe6a66f3284a65f95ad0cc88c3917581 100644 --- a/src/main/java/teetime/framework/AbstractInterThreadPipe.java +++ b/src/main/java/teetime/framework/AbstractInterThreadPipe.java @@ -28,7 +28,7 @@ public abstract class AbstractInterThreadPipe extends AbstractPipe { } } - protected boolean isThreadWaiting(final Thread thread) { + protected final boolean isThreadWaiting(final Thread thread) { return thread.getState() == State.WAITING || thread.getState() == State.TIMED_WAITING; } diff --git a/src/main/java/teetime/framework/AbstractIntraThreadPipe.java b/src/main/java/teetime/framework/AbstractIntraThreadPipe.java index 416a0d6da7edfa9f369fd01df5ca2a1b4624cc6f..4577b1352ff3d1c1a8d79b96e609b3427df5e0b1 100644 --- a/src/main/java/teetime/framework/AbstractIntraThreadPipe.java +++ b/src/main/java/teetime/framework/AbstractIntraThreadPipe.java @@ -10,9 +10,8 @@ public abstract class AbstractIntraThreadPipe extends AbstractPipe { @Override public final void sendSignal(final ISignal signal) { - // if (this.getTargetPort() != null) { // BETTER remove this check since there are DummyPorts + // getTargetPort is always non-null since the framework adds dummy ports if necessary this.cachedTargetStage.onSignal(signal, this.getTargetPort()); - // } } @Override diff --git a/src/main/java/teetime/framework/RunnableConsumerStage.java b/src/main/java/teetime/framework/RunnableConsumerStage.java index 655e0f82f95214cdb6d4c0aff27309e3d08fd687..a68b31024fd013d3e3c4e2fdf613a6fe794c4f83 100644 --- a/src/main/java/teetime/framework/RunnableConsumerStage.java +++ b/src/main/java/teetime/framework/RunnableConsumerStage.java @@ -11,6 +11,12 @@ final class RunnableConsumerStage extends RunnableStage { private final IdleStrategy idleStrategy; + /** + * Creates a new instance with the {@link YieldStrategy} as default idle strategy. + * + * @param stage + * to execute within an own thread + */ public RunnableConsumerStage(final Stage stage) { this(stage, new YieldStrategy()); } diff --git a/src/performancetest/java/teetime/examples/experiment09pipeimpls/ChwHomePerformanceCheck.java b/src/performancetest/java/teetime/examples/experiment09pipeimpls/ChwHomePerformanceCheck.java index b2bc8c82552d56debba916b67b14f043671d9eb6..5b6cd1cb7b5bc30d76893f763b793696bc22e921 100644 --- a/src/performancetest/java/teetime/examples/experiment09pipeimpls/ChwHomePerformanceCheck.java +++ b/src/performancetest/java/teetime/examples/experiment09pipeimpls/ChwHomePerformanceCheck.java @@ -34,7 +34,7 @@ class ChwHomePerformanceCheck extends AbstractPerformanceCheck { // since 31.08.2014 (incl.) // assertEquals(44, medianSpeedup, 2.1); // +2 // since 04.11.2014 (incl.) - // assertEquals(71, medianSpeedup, 2.1); // +33 + // assertEquals(71, medianSpeedup, 2.1); // +27 // since 05.12.2014 (incl.) // assertEquals(45, medianSpeedup, 2.1); // -26 // since 28.12.2014 (incl.)