diff --git a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/BenchmarkStateChecker.kt b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/BenchmarkStateChecker.kt index c2c7db6cd6c5d6a02132353228714c3a3b19ec80..c8be7dbfa2632c531c8da46d7bb09e7510a1d9c0 100644 --- a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/BenchmarkStateChecker.kt +++ b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/BenchmarkStateChecker.kt @@ -195,9 +195,9 @@ class BenchmarkStateChecker( } -private fun <K, V> Map<K, V>.containsMatchLabels(matchLabels: Map<V, V>): Boolean { +private fun <K, V> Map<K, V>.containsMatchLabels(matchLabels: Map<K, V>): Boolean { for (kv in matchLabels) { - if (kv.value != this[kv.key as K]) { + if (kv.value != this[kv.key]) { return false } } diff --git a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/ExecutionEventHandler.kt b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/ExecutionEventHandler.kt index 58120d25d7e26daab015c01fece85cf72344bffa..884606b13783d85ae41c1a8f4c1e5a1980c0e1b0 100644 --- a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/ExecutionEventHandler.kt +++ b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/ExecutionEventHandler.kt @@ -34,7 +34,7 @@ class ExecutionEventHandler( override fun onAdd(execution: ExecutionCRD) { logger.info { "Add execution ${execution.metadata.name}." } execution.spec.name = execution.metadata.name - when (this.stateHandler.getExecutionState(execution.metadata.name)) { + when (val currentState = this.stateHandler.getExecutionState(execution.metadata.name)) { ExecutionState.NO_STATE -> this.stateHandler.setExecutionState(execution.spec.name, ExecutionState.PENDING) ExecutionState.RUNNING -> { this.stateHandler.setExecutionState(execution.spec.name, ExecutionState.RESTART) @@ -42,6 +42,9 @@ class ExecutionEventHandler( this.controller.stop(restart = true) } } + else -> { + logger.info { "ExecutionState '$currentState' is not handled." } + } } } diff --git a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/TheodoliteOperator.kt b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/TheodoliteOperator.kt index 4d639fdb98ea4a890a734f8db0deca62d83fb508..9e9a0eb5aab376b2eece21864df639e2a27a1715 100644 --- a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/TheodoliteOperator.kt +++ b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/operator/TheodoliteOperator.kt @@ -136,7 +136,7 @@ class TheodoliteOperator(private val client: NamespacedKubernetesClient) { ExecutionCRD, BenchmarkExecutionList, Resource<ExecutionCRD>> { - return this.client.customResources( + return client.resources( ExecutionCRD::class.java, BenchmarkExecutionList::class.java ) @@ -146,7 +146,7 @@ class TheodoliteOperator(private val client: NamespacedKubernetesClient) { BenchmarkCRD, KubernetesBenchmarkList, Resource<BenchmarkCRD>> { - return this.client.customResources( + return client.resources( BenchmarkCRD::class.java, KubernetesBenchmarkList::class.java ) diff --git a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/patcher/AbstractPatcher.kt b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/patcher/AbstractPatcher.kt index a20a26b351e730de60497ac014b3aba855ac01f5..0ed2a5e5a8c96761074f998721489f0ddd2db1ac 100644 --- a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/patcher/AbstractPatcher.kt +++ b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/patcher/AbstractPatcher.kt @@ -27,4 +27,4 @@ abstract class AbstractPatcher : Patcher { abstract fun patchSingleResource(resource: HasMetadata, value: String): HasMetadata -} \ No newline at end of file +} diff --git a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/slo/PrometheusResponse.kt b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/slo/PrometheusResponse.kt index 5222a78bde342fea4a94c69bf1e42e132d0bc706..7a3ac237a88390f85b9d49d3f8eba7447621f0f0 100644 --- a/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/slo/PrometheusResponse.kt +++ b/theodolite/src/main/kotlin/rocks/theodolite/kubernetes/slo/PrometheusResponse.kt @@ -31,8 +31,8 @@ data class PrometheusResponse( for (value in values) { val valueList = value as List<*> val timestamp = (valueList[0] as Double).toLong().toString() - val value = valueList[1].toString() - result.add(listOf(group, timestamp, value)) + val resultValue = valueList[1].toString() + result.add(listOf(group, timestamp, resultValue)) } } return Collections.unmodifiableList(result) diff --git a/theodolite/src/test/kotlin/rocks/theodolite/core/ResultsTest.kt b/theodolite/src/test/kotlin/rocks/theodolite/core/ResultsTest.kt index 2dbeb44b90f780975af884028335a7e398c7cfdc..42bc5883f7ebc50c5dde01555b034433b8fa055e 100644 --- a/theodolite/src/test/kotlin/rocks/theodolite/core/ResultsTest.kt +++ b/theodolite/src/test/kotlin/rocks/theodolite/core/ResultsTest.kt @@ -62,7 +62,6 @@ internal class ResultsTest { assertEquals(20000, maxRequiredInstances) } - @Test fun testGetMaxBenchmarkedLoadWhenAllSuccessfulCapacity() { val results = Results(Metric.from("capacity")) diff --git a/theodolite/src/test/kotlin/rocks/theodolite/kubernetes/operator/ControllerTest.kt b/theodolite/src/test/kotlin/rocks/theodolite/kubernetes/operator/ControllerTest.kt index bdb7cc6ce4c0a6044878496eed3f99efe105c17d..301580bf3f84faaef8df22555d22a33dff0d2acd 100644 --- a/theodolite/src/test/kotlin/rocks/theodolite/kubernetes/operator/ControllerTest.kt +++ b/theodolite/src/test/kotlin/rocks/theodolite/kubernetes/operator/ControllerTest.kt @@ -113,6 +113,7 @@ class ControllerTest { .getDeclaredMethod("getBenchmarks") method.isAccessible = true + @Suppress("UNCHECKED_CAST") val result = method.invoke(controller) as List<BenchmarkCRD> assertEquals(2, result.size)