From 618f3627e0c41c4275ee53b71ad9a22ff573b4ae Mon Sep 17 00:00:00 2001
From: Simon Ehrenstein <simon.ehrenstein@gmail.com>
Date: Sun, 14 Jun 2020 20:52:09 +0200
Subject: [PATCH] Fix static analysis violations
---
.../communication/zookeeper/WorkloadDistributor.java | 4 ++--
.../generators/KafkaWorkloadGeneratorBuilder.java | 2 +-
.../theodolite/commons/workloadgeneration/misc/ZooKeeper.java | 1 -
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java b/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java
index ce7d78d77..454073850 100644
--- a/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java
+++ b/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java
@@ -71,8 +71,8 @@ public class WorkloadDistributor {
try {
this.client.blockUntilConnected();
} catch (final InterruptedException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
+ LOGGER.error("", e);
+ throw new IllegalStateException();
}
this.counter =
diff --git a/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java b/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java
index 7a435fca6..afb232f71 100644
--- a/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java
+++ b/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java
@@ -9,7 +9,7 @@ import theodolite.commons.workloadgeneration.functions.BeforeAction;
import theodolite.commons.workloadgeneration.functions.MessageGenerator;
import theodolite.commons.workloadgeneration.misc.ZooKeeper;
-public class KafkaWorkloadGeneratorBuilder<T extends IMonitoringRecord> {
+public final class KafkaWorkloadGeneratorBuilder<T extends IMonitoringRecord> {
private int instances;
diff --git a/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/ZooKeeper.java b/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/ZooKeeper.java
index 3e6393b0d..9f8ac9228 100644
--- a/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/ZooKeeper.java
+++ b/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/ZooKeeper.java
@@ -15,7 +15,6 @@ public class ZooKeeper {
* @param port of zookeeper.
*/
public ZooKeeper(final String host, final int port) {
- super();
this.host = host;
this.port = port;
}
--
GitLab