From 67c3dbd02efbc8b9ea7d59ed85533d6a154780ef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B6ren=20Henning?= <soeren.henning@email.uni-kiel.de>
Date: Sun, 27 Nov 2022 11:56:37 +0100
Subject: [PATCH] Make `disableMetrics` and `fasterCopy` configurable

---
 .../uc1-beam-flink/resources/jobmanager-deployment.yaml   | 8 ++++++--
 .../uc2-beam-flink/resources/jobmanager-deployment.yaml   | 8 ++++++--
 .../uc3-beam-flink/resources/jobmanager-deployment.yaml   | 8 ++++++--
 .../uc4-beam-flink/resources/jobmanager-deployment.yaml   | 8 ++++++--
 4 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/theodolite-benchmarks/definitions/uc1-beam-flink/resources/jobmanager-deployment.yaml b/theodolite-benchmarks/definitions/uc1-beam-flink/resources/jobmanager-deployment.yaml
index 036475695..c9b48c83a 100644
--- a/theodolite-benchmarks/definitions/uc1-beam-flink/resources/jobmanager-deployment.yaml
+++ b/theodolite-benchmarks/definitions/uc1-beam-flink/resources/jobmanager-deployment.yaml
@@ -20,8 +20,8 @@ spec:
           image: ghcr.io/cau-se/theodolite-uc1-beam-flink:latest
           args: ["standalone-job", "--job-classname", "rocks.theodolite.benchmarks.uc1.beam.flink.Uc1BeamFlink",
                   "--parallelism=$(PARALLELISM)",
-                  "--disableMetrics=true",
-                  "--fasterCopy"]
+                  "--disableMetrics=$(DISABLE_METRICS)",
+                  "--fasterCopy=$(FASTER_COPY)"]
           # optional arguments: ["--job-id", "<job id>", "--fromSavepoint", "/path/to/savepoint", "--allowNonRestoredState"]
           env:
             - name: KAFKA_BOOTSTRAP_SERVERS
@@ -32,6 +32,10 @@ spec:
               value: "false"
             - name: PARALLELISM
               value: "1"
+            - name: DISABLE_METRICS
+              value: "true"
+            - name: FASTER_COPY
+              value: "true"
             - name: "FLINK_STATE_BACKEND"
               value: "rocksdb"
             - name: JOB_MANAGER_RPC_ADDRESS
diff --git a/theodolite-benchmarks/definitions/uc2-beam-flink/resources/jobmanager-deployment.yaml b/theodolite-benchmarks/definitions/uc2-beam-flink/resources/jobmanager-deployment.yaml
index 961a68acf..27c0a5082 100644
--- a/theodolite-benchmarks/definitions/uc2-beam-flink/resources/jobmanager-deployment.yaml
+++ b/theodolite-benchmarks/definitions/uc2-beam-flink/resources/jobmanager-deployment.yaml
@@ -20,8 +20,8 @@ spec:
           image: ghcr.io/cau-se/theodolite-uc2-beam-flink:latest
           args: ["standalone-job", "--job-classname", "rocks.theodolite.benchmarks.uc2.beam.flink.Uc2BeamFlink",
                   "--parallelism=$(PARALLELISM)",
-                  "--disableMetrics=true",
-                  "--fasterCopy"]
+                  "--disableMetrics=$(DISABLE_METRICS)",
+                  "--fasterCopy=$(FASTER_COPY)"]
           # optional arguments: ["--job-id", "<job id>", "--fromSavepoint", "/path/to/savepoint", "--allowNonRestoredState"]
           env:
             - name: KAFKA_BOOTSTRAP_SERVERS
@@ -32,6 +32,10 @@ spec:
               value: "false"
             - name: PARALLELISM
               value: "1"
+            - name: DISABLE_METRICS
+              value: "true"
+            - name: FASTER_COPY
+              value: "true"
             - name: "FLINK_STATE_BACKEND"
               value: "rocksdb"
             - name: JOB_MANAGER_RPC_ADDRESS
diff --git a/theodolite-benchmarks/definitions/uc3-beam-flink/resources/jobmanager-deployment.yaml b/theodolite-benchmarks/definitions/uc3-beam-flink/resources/jobmanager-deployment.yaml
index 62a6d6615..d1b7b9b51 100644
--- a/theodolite-benchmarks/definitions/uc3-beam-flink/resources/jobmanager-deployment.yaml
+++ b/theodolite-benchmarks/definitions/uc3-beam-flink/resources/jobmanager-deployment.yaml
@@ -20,8 +20,8 @@ spec:
           image: ghcr.io/cau-se/theodolite-uc3-beam-flink:latest
           args: ["standalone-job", "--job-classname", "rocks.theodolite.benchmarks.uc3.beam.flink.Uc3BeamFlink",
                   "--parallelism=$(PARALLELISM)",
-                  "--disableMetrics=true",
-                  "--fasterCopy"]
+                  "--disableMetrics=$(DISABLE_METRICS)",
+                  "--fasterCopy=$(FASTER_COPY)"]
           # optional arguments: ["--job-id", "<job id>", "--fromSavepoint", "/path/to/savepoint", "--allowNonRestoredState"]
           env:
             - name: KAFKA_BOOTSTRAP_SERVERS
@@ -32,6 +32,10 @@ spec:
               value: "false"
             - name: PARALLELISM
               value: "1"
+            - name: DISABLE_METRICS
+              value: "true"
+            - name: FASTER_COPY
+              value: "true"
             - name: "FLINK_STATE_BACKEND"
               value: "rocksdb"
             - name: JOB_MANAGER_RPC_ADDRESS
diff --git a/theodolite-benchmarks/definitions/uc4-beam-flink/resources/jobmanager-deployment.yaml b/theodolite-benchmarks/definitions/uc4-beam-flink/resources/jobmanager-deployment.yaml
index 4deb0cb21..7dbcd62cc 100644
--- a/theodolite-benchmarks/definitions/uc4-beam-flink/resources/jobmanager-deployment.yaml
+++ b/theodolite-benchmarks/definitions/uc4-beam-flink/resources/jobmanager-deployment.yaml
@@ -20,8 +20,8 @@ spec:
           image: ghcr.io/cau-se/theodolite-uc4-beam-flink:latest
           args: ["standalone-job", "--job-classname", "rocks.theodolite.benchmarks.uc4.beam.flink.Uc4BeamFlink",
                   "--parallelism=$(PARALLELISM)",
-                  "--disableMetrics=true",
-                  "--fasterCopy"]
+                  "--disableMetrics=$(DISABLE_METRICS)",
+                  "--fasterCopy=$(FASTER_COPY)"]
           # optional arguments: ["--job-id", "<job id>", "--fromSavepoint", "/path/to/savepoint", "--allowNonRestoredState"]
           env:
             - name: KAFKA_BOOTSTRAP_SERVERS
@@ -32,6 +32,10 @@ spec:
               value: "false"
             - name: PARALLELISM
               value: "1"
+            - name: DISABLE_METRICS
+              value: "true"
+            - name: FASTER_COPY
+              value: "true"
             - name: "FLINK_STATE_BACKEND"
               value: "rocksdb"
             - name: JOB_MANAGER_RPC_ADDRESS
-- 
GitLab