From 8527d2d85a0434b12b684a3a17b6c1e70a33aa14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=B6ren=20Henning?= <soeren.henning@email.uni-kiel.de> Date: Wed, 24 Feb 2021 12:14:48 +0100 Subject: [PATCH] Refactor package structure --- .../theodolite/uc2/workloadgenerator/LoadGenerator.java | 2 +- .../theodolite/uc3/workloadgenerator/LoadGenerator.java | 2 +- .../theodolite/uc4/workloadgenerator/LoadGenerator.java | 2 +- .../workloadgeneration/{functions => }/BeforeAction.java | 2 +- .../{communication/kafka => }/KafkaRecordSender.java | 3 +-- .../commons/workloadgeneration/LoadGenerator.java | 2 -- .../commons/workloadgeneration/LoadGeneratorConfig.java | 2 -- .../commons/workloadgeneration/LoadGeneratorExecution.java | 1 - .../{functions => }/MessageGenerator.java | 2 +- .../workloadgeneration/{functions => }/RecordGenerator.java | 2 +- .../workloadgeneration/{functions => }/RecordSender.java | 2 +- .../{functions => }/TitanMessageGeneratorFactory.java | 3 +-- .../communication/zookeeper/WorkloadDistributor.java | 2 +- .../generators/AbstractWorkloadGenerator.java | 6 +++--- .../generators/KafkaWorkloadGenerator.java | 6 +++--- .../generators/KafkaWorkloadGeneratorBuilder.java | 6 +++--- .../commons/workloadgeneration/misc/WorkloadEntity.java | 2 +- 17 files changed, 20 insertions(+), 27 deletions(-) rename benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/{functions => }/BeforeAction.java (80%) rename benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/{communication/kafka => }/KafkaRecordSender.java (96%) rename benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/{functions => }/MessageGenerator.java (87%) rename benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/{functions => }/RecordGenerator.java (84%) rename benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/{functions => }/RecordSender.java (85%) rename benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/{functions => }/TitanMessageGeneratorFactory.java (92%) diff --git a/benchmarks/uc2-workload-generator/src/main/java/theodolite/uc2/workloadgenerator/LoadGenerator.java b/benchmarks/uc2-workload-generator/src/main/java/theodolite/uc2/workloadgenerator/LoadGenerator.java index 84683a0e8..3fbde336f 100644 --- a/benchmarks/uc2-workload-generator/src/main/java/theodolite/uc2/workloadgenerator/LoadGenerator.java +++ b/benchmarks/uc2-workload-generator/src/main/java/theodolite/uc2/workloadgenerator/LoadGenerator.java @@ -8,8 +8,8 @@ import java.util.Properties; import org.apache.kafka.clients.producer.ProducerConfig; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import theodolite.commons.workloadgeneration.KafkaRecordSender; import theodolite.commons.workloadgeneration.KeySpace; -import theodolite.commons.workloadgeneration.communication.kafka.KafkaRecordSender; import theodolite.commons.workloadgeneration.generators.KafkaWorkloadGenerator; import theodolite.commons.workloadgeneration.generators.KafkaWorkloadGeneratorBuilder; import theodolite.commons.workloadgeneration.misc.ZooKeeper; diff --git a/benchmarks/uc3-workload-generator/src/main/java/theodolite/uc3/workloadgenerator/LoadGenerator.java b/benchmarks/uc3-workload-generator/src/main/java/theodolite/uc3/workloadgenerator/LoadGenerator.java index 5e0532bc5..41cdc4a19 100644 --- a/benchmarks/uc3-workload-generator/src/main/java/theodolite/uc3/workloadgenerator/LoadGenerator.java +++ b/benchmarks/uc3-workload-generator/src/main/java/theodolite/uc3/workloadgenerator/LoadGenerator.java @@ -8,8 +8,8 @@ import java.util.Properties; import org.apache.kafka.clients.producer.ProducerConfig; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import theodolite.commons.workloadgeneration.KafkaRecordSender; import theodolite.commons.workloadgeneration.KeySpace; -import theodolite.commons.workloadgeneration.communication.kafka.KafkaRecordSender; import theodolite.commons.workloadgeneration.generators.KafkaWorkloadGenerator; import theodolite.commons.workloadgeneration.generators.KafkaWorkloadGeneratorBuilder; import theodolite.commons.workloadgeneration.misc.ZooKeeper; diff --git a/benchmarks/uc4-workload-generator/src/main/java/theodolite/uc4/workloadgenerator/LoadGenerator.java b/benchmarks/uc4-workload-generator/src/main/java/theodolite/uc4/workloadgenerator/LoadGenerator.java index 1ce8eebde..892498e17 100644 --- a/benchmarks/uc4-workload-generator/src/main/java/theodolite/uc4/workloadgenerator/LoadGenerator.java +++ b/benchmarks/uc4-workload-generator/src/main/java/theodolite/uc4/workloadgenerator/LoadGenerator.java @@ -8,8 +8,8 @@ import java.util.Properties; import org.apache.kafka.clients.producer.ProducerConfig; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import theodolite.commons.workloadgeneration.KafkaRecordSender; import theodolite.commons.workloadgeneration.KeySpace; -import theodolite.commons.workloadgeneration.communication.kafka.KafkaRecordSender; import theodolite.commons.workloadgeneration.generators.KafkaWorkloadGenerator; import theodolite.commons.workloadgeneration.generators.KafkaWorkloadGeneratorBuilder; import theodolite.commons.workloadgeneration.misc.ZooKeeper; diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/BeforeAction.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/BeforeAction.java similarity index 80% rename from benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/BeforeAction.java rename to benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/BeforeAction.java index 0010bb5cc..56af95d70 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/BeforeAction.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/BeforeAction.java @@ -1,4 +1,4 @@ -package theodolite.commons.workloadgeneration.functions; +package theodolite.commons.workloadgeneration; /** * Describes the before action which is executed before every sub experiment. diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/kafka/KafkaRecordSender.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/KafkaRecordSender.java similarity index 96% rename from benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/kafka/KafkaRecordSender.java rename to benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/KafkaRecordSender.java index 35ce089c5..dd17234bf 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/kafka/KafkaRecordSender.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/KafkaRecordSender.java @@ -1,4 +1,4 @@ -package theodolite.commons.workloadgeneration.communication.kafka; +package theodolite.commons.workloadgeneration; import java.util.Properties; import java.util.function.Function; @@ -9,7 +9,6 @@ import org.apache.kafka.clients.producer.ProducerRecord; import org.apache.kafka.common.serialization.StringSerializer; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import theodolite.commons.workloadgeneration.functions.RecordSender; import titan.ccp.common.kafka.avro.SchemaRegistryAvroSerdeFactory; /** diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGenerator.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGenerator.java index 55aed822d..fdbd31ad4 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGenerator.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGenerator.java @@ -4,8 +4,6 @@ import java.time.Duration; import java.util.Objects; import java.util.Properties; import org.apache.kafka.clients.producer.ProducerConfig; -import theodolite.commons.workloadgeneration.functions.BeforeAction; -import theodolite.commons.workloadgeneration.functions.TitanMessageGeneratorFactory; public final class LoadGenerator { diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorConfig.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorConfig.java index 3d76b1c85..f8a9647a6 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorConfig.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorConfig.java @@ -2,8 +2,6 @@ package theodolite.commons.workloadgeneration; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import theodolite.commons.workloadgeneration.functions.BeforeAction; -import theodolite.commons.workloadgeneration.functions.MessageGenerator; public class LoadGeneratorConfig { diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorExecution.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorExecution.java index e666ef9b4..184bf686b 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorExecution.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/LoadGeneratorExecution.java @@ -6,7 +6,6 @@ import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.TimeUnit; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import theodolite.commons.workloadgeneration.functions.MessageGenerator; public class LoadGeneratorExecution { diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/MessageGenerator.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/MessageGenerator.java similarity index 87% rename from benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/MessageGenerator.java rename to benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/MessageGenerator.java index f59423b95..c369f1655 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/MessageGenerator.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/MessageGenerator.java @@ -1,4 +1,4 @@ -package theodolite.commons.workloadgeneration.functions; +package theodolite.commons.workloadgeneration; /** * Interface representing a message generator, which sends messages for given keys to some diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/RecordGenerator.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/RecordGenerator.java similarity index 84% rename from benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/RecordGenerator.java rename to benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/RecordGenerator.java index 4a94d8c3b..ea6501f38 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/RecordGenerator.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/RecordGenerator.java @@ -1,4 +1,4 @@ -package theodolite.commons.workloadgeneration.functions; +package theodolite.commons.workloadgeneration; /** * This interface describes a function that takes meta information from a string key and produces an diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/RecordSender.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/RecordSender.java similarity index 85% rename from benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/RecordSender.java rename to benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/RecordSender.java index 6f912779d..ee57f2f23 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/RecordSender.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/RecordSender.java @@ -1,4 +1,4 @@ -package theodolite.commons.workloadgeneration.functions; +package theodolite.commons.workloadgeneration; /** * This interface describes a function that consumes a message {@code T}. This function is dedicated diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/TitanMessageGeneratorFactory.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/TitanMessageGeneratorFactory.java similarity index 92% rename from benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/TitanMessageGeneratorFactory.java rename to benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/TitanMessageGeneratorFactory.java index 2fd784e80..bd0b41d4e 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/functions/TitanMessageGeneratorFactory.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/TitanMessageGeneratorFactory.java @@ -1,7 +1,6 @@ -package theodolite.commons.workloadgeneration.functions; +package theodolite.commons.workloadgeneration; import java.util.Properties; -import theodolite.commons.workloadgeneration.communication.kafka.KafkaRecordSender; import titan.ccp.model.records.ActivePowerRecord; /** diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java index 832d575a9..095efa839 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/communication/zookeeper/WorkloadDistributor.java @@ -14,8 +14,8 @@ import org.apache.zookeeper.Watcher.Event.EventType; import org.apache.zookeeper.data.Stat; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import theodolite.commons.workloadgeneration.BeforeAction; import theodolite.commons.workloadgeneration.KeySpace; -import theodolite.commons.workloadgeneration.functions.BeforeAction; import theodolite.commons.workloadgeneration.misc.WorkloadDefinition; import theodolite.commons.workloadgeneration.misc.ZooKeeper; diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/AbstractWorkloadGenerator.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/AbstractWorkloadGenerator.java index 68376d099..1e4fd6c25 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/AbstractWorkloadGenerator.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/AbstractWorkloadGenerator.java @@ -11,11 +11,11 @@ import java.util.function.BiConsumer; import java.util.function.BiFunction; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import theodolite.commons.workloadgeneration.BeforeAction; import theodolite.commons.workloadgeneration.KeySpace; +import theodolite.commons.workloadgeneration.RecordGenerator; +import theodolite.commons.workloadgeneration.RecordSender; import theodolite.commons.workloadgeneration.communication.zookeeper.WorkloadDistributor; -import theodolite.commons.workloadgeneration.functions.BeforeAction; -import theodolite.commons.workloadgeneration.functions.RecordGenerator; -import theodolite.commons.workloadgeneration.functions.RecordSender; import theodolite.commons.workloadgeneration.misc.WorkloadDefinition; import theodolite.commons.workloadgeneration.misc.WorkloadEntity; import theodolite.commons.workloadgeneration.misc.ZooKeeper; diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGenerator.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGenerator.java index 2186454af..49bdf655b 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGenerator.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGenerator.java @@ -2,10 +2,10 @@ package theodolite.commons.workloadgeneration.generators; import java.time.Duration; import org.apache.avro.specific.SpecificRecord; +import theodolite.commons.workloadgeneration.BeforeAction; +import theodolite.commons.workloadgeneration.KafkaRecordSender; import theodolite.commons.workloadgeneration.KeySpace; -import theodolite.commons.workloadgeneration.communication.kafka.KafkaRecordSender; -import theodolite.commons.workloadgeneration.functions.BeforeAction; -import theodolite.commons.workloadgeneration.functions.RecordGenerator; +import theodolite.commons.workloadgeneration.RecordGenerator; import theodolite.commons.workloadgeneration.misc.ZooKeeper; /** diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java index 76f0d024a..9252d5dcf 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/generators/KafkaWorkloadGeneratorBuilder.java @@ -3,10 +3,10 @@ package theodolite.commons.workloadgeneration.generators; import java.time.Duration; import java.util.Objects; import org.apache.avro.specific.SpecificRecord; +import theodolite.commons.workloadgeneration.BeforeAction; +import theodolite.commons.workloadgeneration.KafkaRecordSender; import theodolite.commons.workloadgeneration.KeySpace; -import theodolite.commons.workloadgeneration.communication.kafka.KafkaRecordSender; -import theodolite.commons.workloadgeneration.functions.BeforeAction; -import theodolite.commons.workloadgeneration.functions.RecordGenerator; +import theodolite.commons.workloadgeneration.RecordGenerator; import theodolite.commons.workloadgeneration.misc.ZooKeeper; /** diff --git a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/WorkloadEntity.java b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/WorkloadEntity.java index 3f044d40b..55d240281 100644 --- a/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/WorkloadEntity.java +++ b/benchmarks/workload-generator-commons/src/main/java/theodolite/commons/workloadgeneration/misc/WorkloadEntity.java @@ -1,6 +1,6 @@ package theodolite.commons.workloadgeneration.misc; -import theodolite.commons.workloadgeneration.functions.RecordGenerator; +import theodolite.commons.workloadgeneration.RecordGenerator; /** * Representation of a entity of the workload generation that generates load for one fixed key. -- GitLab