From a7bbf1c9d249d70e731bedff775fd05c3db07e17 Mon Sep 17 00:00:00 2001
From: lorenz <stu203404@mail.uni-kiel.de>
Date: Fri, 19 Nov 2021 11:28:19 +0100
Subject: [PATCH] Fix pmd and checkstyle uc1+uc2 beam
---
.../src/main/java/application/Uc1BeamPipeline.java | 7 +------
.../src/main/java/application/Uc2BeamPipeline.java | 6 +++---
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/theodolite-benchmarks/uc1-beam/src/main/java/application/Uc1BeamPipeline.java b/theodolite-benchmarks/uc1-beam/src/main/java/application/Uc1BeamPipeline.java
index f43f50890..dc2898263 100644
--- a/theodolite-benchmarks/uc1-beam/src/main/java/application/Uc1BeamPipeline.java
+++ b/theodolite-benchmarks/uc1-beam/src/main/java/application/Uc1BeamPipeline.java
@@ -11,10 +11,7 @@ import org.apache.beam.sdk.values.KV;
import org.apache.beam.sdk.values.PBegin;
import org.apache.beam.sdk.values.PCollection;
import org.apache.commons.configuration2.Configuration;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import theodolite.commons.beam.AbstractPipeline;
-import theodolite.commons.beam.ConfigurationKeys;
import theodolite.commons.beam.kafka.KafkaActivePowerRecordReader;
import titan.ccp.model.records.ActivePowerRecord;
@@ -29,9 +26,7 @@ import titan.ccp.model.records.ActivePowerRecord;
*/
public final class Uc1BeamPipeline extends AbstractPipeline {
- private static final Logger LOGGER = LoggerFactory.getLogger(Uc1BeamPipeline.class);
-
- Uc1BeamPipeline(PipelineOptions options, Configuration config) {
+ protected Uc1BeamPipeline(final PipelineOptions options, final Configuration config) {
super(options, config);
// Set Coders for Classes that will be distributed
diff --git a/theodolite-benchmarks/uc2-beam/src/main/java/application/Uc2BeamPipeline.java b/theodolite-benchmarks/uc2-beam/src/main/java/application/Uc2BeamPipeline.java
index 78988e4cb..fa7d455e3 100644
--- a/theodolite-benchmarks/uc2-beam/src/main/java/application/Uc2BeamPipeline.java
+++ b/theodolite-benchmarks/uc2-beam/src/main/java/application/Uc2BeamPipeline.java
@@ -38,17 +38,17 @@ import titan.ccp.model.records.ActivePowerRecord;
*/
public final class Uc2BeamPipeline extends AbstractPipeline {
- protected Uc2BeamPipeline(PipelineOptions options, Configuration config) {
+ protected Uc2BeamPipeline(final PipelineOptions options,final Configuration config) {
super(options, config);
// Additional needed variables
- String outputTopic = config.getString(ConfigurationKeys.KAFKA_OUTPUT_TOPIC);
+ final String outputTopic = config.getString(ConfigurationKeys.KAFKA_OUTPUT_TOPIC);
final int windowDurationMinutes = Integer.parseInt(
config.getString(ConfigurationKeys.KAFKA_WINDOW_DURATION_MINUTES));
final Duration duration = Duration.standardMinutes(windowDurationMinutes);
// Build kafka configuration
- Properties consumerConfig = buildConsumerConfig();
+ final Properties consumerConfig = buildConsumerConfig();
// Set Coders for Classes that will be distributed
final CoderRegistry cr = this.getCoderRegistry();
--
GitLab