Skip to content
Snippets Groups Projects
Commit 052ac553 authored by Nils Christian Ehmke's avatar Nils Christian Ehmke
Browse files

Modified some configuration files for quality reasons.

parent b896ea67
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Kieker.WebGUI/.project
+ 18
− 0
View file @ 052ac553
...@@ -15,9 +15,27 @@ ...@@ -15,9 +15,27 @@
<arguments> <arguments>
</arguments> </arguments>
</buildCommand> </buildCommand>
<buildCommand>
<name>net.sourceforge.pmd.eclipse.plugin.pmdBuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>edu.umd.cs.findbugs.plugin.eclipse.findbugsBuilder</name>
<arguments>
</arguments>
</buildCommand>
<buildCommand>
<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
<arguments>
</arguments>
</buildCommand>
</buildSpec> </buildSpec>
<natures> <natures>
<nature>org.eclipse.m2e.core.maven2Nature</nature> <nature>org.eclipse.m2e.core.maven2Nature</nature>
<nature>org.eclipse.jdt.core.javanature</nature> <nature>org.eclipse.jdt.core.javanature</nature>
<nature>net.sourceforge.pmd.eclipse.plugin.pmdNature</nature>
<nature>edu.umd.cs.findbugs.plugin.eclipse.findbugsNature</nature>
<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
</natures> </natures>
</projectDescription> </projectDescription>
Kieker.WebGUI/.settings/edu.umd.cs.findbugs.core.prefs
+ 4
− 4
View file @ 052ac553
#FindBugs User Preferences #FindBugs User Preferences
#Fri May 18 17:56:48 CEST 2012 #Wed Jul 11 22:19:24 CEST 2012
cloud_id=edu.umd.cs.findbugs.cloud.doNothingCloud cloud_id=edu.umd.cs.findbugs.cloud.doNothingCloud
detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true
detectorAtomicityProblem=AtomicityProblem|true detectorAtomicityProblem=AtomicityProblem|true
...@@ -125,7 +125,7 @@ detectorWaitInLoop=WaitInLoop|true ...@@ -125,7 +125,7 @@ detectorWaitInLoop=WaitInLoop|true
detectorWrongMapIterator=WrongMapIterator|true detectorWrongMapIterator=WrongMapIterator|true
detectorXMLFactoryBypass=XMLFactoryBypass|true detectorXMLFactoryBypass=XMLFactoryBypass|true
detector_threshold=2 detector_threshold=2
effort=default effort=max
filter_settings=Medium|BAD_PRACTICE,CORRECTNESS,MT_CORRECTNESS,PERFORMANCE,STYLE|false|15 filter_settings=Medium|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MALICIOUS_CODE,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false|15
filter_settings_neg=MALICIOUS_CODE,NOISE,I18N,SECURITY,EXPERIMENTAL| filter_settings_neg=NOISE|
run_at_full_build=false run_at_full_build=false
Kieker.WebGUI/config/quality-config/fb-filter.xml
+ 0
− 195
View file @ 052ac553
<FindBugsFilter> <FindBugsFilter>
<!-- Example: http://findbugs.sourceforge.net/manual/filter.html#d0e2103 --> <!-- Example: http://findbugs.sourceforge.net/manual/filter.html#d0e2103 -->
<Match>
<Class
name="kieker.monitoring.probe.servlet.SessionAndTraceRegistrationFilter" />
<Method name="doFilter"
params="javax.servlet.ServletRequest, javax.servlet.ServletResponse, javax.servlet.FilterChain"
returns="void" />
<Bug pattern="ES_COMPARING_STRINGS_WITH_EQ" />
</Match>
<Match>
<Class name="kieker.tools.KaxViz" />
<Method name="main" params="java.lang.String[]" returns="void" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Class name="kieker.analysis.AnalysisController" />
<Method name="getCurrentConfiguration" params=""
returns="kieker.analysis.model.analysisMetaModel.MIProject" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.database.DbReader" />
<Method name="read" params="" returns="boolean" />
<Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.database.DbReader" />
<Method name="table2record"
params="java.sql.Connection,java.lang.String,java.lang.Class"
returns="void" />
<Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE" />
</Match>
<Match>
<Class name="kieker.monitoring.writer.database.DbWriterThread" />
<Method name="consume" params="kieker.common.record.IMonitoringRecord"
returns="void" />
<Bug pattern="OBL_UNSATISFIED_OBLIGATION" />
</Match>
<Match>
<Class name="kieker.monitoring.writer.database.DbWriterThread" />
<Method name="consume" params="kieker.common.record.IMonitoringRecord"
returns="void" />
<Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" />
</Match>
<Match>
<Class name="kieker.monitoring.writer.database.SyncDbWriter" />
<Method name="newMonitoringRecord" params="kieker.common.record.IMonitoringRecord"
returns="boolean" />
<Bug pattern="OBL_UNSATISFIED_OBLIGATION" />
</Match>
<Match>
<Class name="kieker.monitoring.writer.database.SyncDbWriter" />
<Method name="newMonitoringRecord" params="kieker.common.record.IMonitoringRecord"
returns="boolean" />
<Bug pattern="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" />
</Match>
<Match>
<Class name="kieker.monitoring.writer.database.DBWriterHelper" />
<Method name="createTable" params="java.lang.String,java.lang.Class[]"
returns="java.lang.String" />
<Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE" />
</Match>
<Match>
<Class name="kieker.monitoring.writer.database.DBWriterHelper" />
<Method name="createIndexTable" params="" returns="void" />
<Bug pattern="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE" />
</Match>
<Match>
<Class name="kieker.evaluation.benchmark.Benchmark" />
<Method name="parseAndInitializeArguments" params="java.lang.String[]"
returns="void" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Class name="kieker.monitoring.timer.AbstractTimeSource" />
<Method name="toString" params="" returns="java.lang.String" />
<Bug pattern="USM_USELESS_ABSTRACT_METHOD" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.jmx.JMXReader" />
<Method name="read2" params="" returns="boolean" />
<Bug pattern="DE_MIGHT_IGNORE" />
</Match>
<Match>
<Class name="kieker.common.logging.LogFactory" />
<Bug pattern="DE_MIGHT_IGNORE" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.filesystem.FSReader" />
<Method name="read" params="" returns="boolean" />
<Bug pattern="NN_NAKED_NOTIFY" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.filesystem.FSReader" />
<Method name="newMonitoringRecord" params="kieker.common.record.IMonitoringRecord"
returns="boolean" />
<Bug pattern="WA_NOT_IN_LOOP" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.filesystem.FSReader" />
<Method name="newMonitoringRecord" params="kieker.common.record.IMonitoringRecord"
returns="boolean" />
<Bug pattern="UW_UNCOND_WAIT" />
</Match>
<Match>
<Class name="kieker.monitoring.core.registry.Registry" />
<Field name="eArrayCached" />
<Bug pattern="VO_VOLATILE_REFERENCE_TO_ARRAY" />
</Match>
<Match>
<Class name="org.apache.commons.logging.impl.Jdk14LoggerPatched" />
<Method name="getLog" params="java.lang.String" returns="org.apache.commons.logging.Log" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.filesystem.FSDirectoryReader" />
<Method name="processNormalInputFile" params="java.io.File"
returns="void" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Class name="kieker.analysis.plugin.reader.filesystem.FSDirectoryReader" />
<Method name="processBinaryInputFile" params="java.io.File"
returns="void" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Class name="kieker.monitoring.core.controller.JMXController" />
<Method name="&lt;init&gt;" params="kieker.common.configuration.Configuration"
returns="void" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Class name="kieker.tools.traceAnalysis.TraceAnalysisTool" />
<Method name="dispatchTasks" params="" returns="boolean" />
<Bug pattern="REC_CATCH_EXCEPTION" />
</Match>
<Match>
<Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
</Match>
<Match>
<Package name="~kieker\.analysis\.model\.analysisMetaModel.*" />
<Bug pattern="IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION" />
</Match>
<Match>
<Package name="~kieker\.analysis\.model\.analysisMetaModel.*" />
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE" />
</Match>
<Match>
<Package name="~kieker\.analysis\.model\.analysisMetaModel.*" />
<Bug pattern="BC_UNCONFIRMED_CAST" />
</Match>
<Match>
<Package name="~kieker\.analysis\.model\.analysisMetaModel.*" />
<Bug pattern="NP_LOAD_OF_KNOWN_NULL_VALUE" />
</Match>
<Match>
<Package name="~kieker\.analysis\.model\.analysisMetaModel.*" />
<Bug pattern="NM_CONFUSING" />
</Match>
<Match>
<Package name="~kieker\.analysis\.model\.analysisMetaModel.*" />
<Bug pattern="MS_PKGPROTECT" />
</Match>
</FindBugsFilter> </FindBugsFilter>
\ No newline at end of file
Kieker.WebGUI/config/quality-config/pmdrules.xml
+ 0
− 5
View file @ 052ac553
...@@ -7,11 +7,6 @@ ...@@ -7,11 +7,6 @@
<description> <description>
This ruleset is checked for Kieker automatically. This ruleset is checked for Kieker automatically.
</description> </description>
<!-- exclude generated code -->
<exclude-pattern>.*/src-gen/.*</exclude-pattern>
<!-- exclude userguide examples -->
<exclude-pattern>.*/examples/userguide/.*</exclude-pattern>
<!-- We'll use the following rulesets --> <!-- We'll use the following rulesets -->
<rule ref="rulesets/basic.xml"> <rule ref="rulesets/basic.xml">
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment