Skip to content
Snippets Groups Projects
Commit 08c1872f authored by Christian Wulf's avatar Christian Wulf
Browse files

added null check for SingleElementPipe (test is still missing)

parent b2955e13
No related branches found
No related tags found
No related merge requests found
#FindBugs User Preferences
#Tue Apr 28 16:12:41 CEST 2015
#Thu Apr 30 13:44:10 CEST 2015
detector_threshold=3
effort=max
excludefilter0=.fbExcludeFilterFile|true
......
......@@ -128,11 +128,10 @@ public final class Analysis<T extends AnalysisConfiguration> implements Uncaught
if (threadableStageJobs.isEmpty()) {
throw new IllegalStateException("No stage was added using the addThreadableStage(..) method. Add at least one stage.");
}
AbstractExceptionListener newListener;
Set<Stage> intraStages;
for (Stage stage : threadableStageJobs) {
intraStages = traverseIntraStages(stage);
newListener = factory.createInstance();
Set<Stage> intraStages = traverseIntraStages(stage);
AbstractExceptionListener newListener = factory.createInstance();
switch (stage.getTerminationStrategy()) {
case BY_SIGNAL: {
final RunnableConsumerStage runnable = new RunnableConsumerStage(stage);
......
......@@ -35,9 +35,12 @@ public final class SingleElementPipe extends AbstractIntraThreadPipe {
@Override
public boolean add(final Object element) {
this.element = element;
this.reportNewElement();
return true;
if (null != element) {
this.element = element;
this.reportNewElement();
return true;
}
return false;
}
@Override
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment