Skip to content
Snippets Groups Projects
Commit 41fff673 authored by Nelson Tavares de Sousa's avatar Nelson Tavares de Sousa
Browse files

better thread termination

parent 9dd71047
No related branches found
No related tags found
No related merge requests found
...@@ -271,6 +271,7 @@ public abstract class AbstractStage extends Stage { ...@@ -271,6 +271,7 @@ public abstract class AbstractStage extends Stage {
@Override @Override
protected void terminate() { protected void terminate() {
changeState(StageState.TERMINATING); changeState(StageState.TERMINATING);
owningThread.interrupt();
} }
@Override @Override
......
...@@ -19,6 +19,7 @@ import teetime.framework.AbstractInterThreadPipe; ...@@ -19,6 +19,7 @@ import teetime.framework.AbstractInterThreadPipe;
import teetime.framework.InputPort; import teetime.framework.InputPort;
import teetime.framework.OutputPort; import teetime.framework.OutputPort;
import teetime.framework.StageState; import teetime.framework.StageState;
import teetime.framework.exceptionHandling.TerminateException;
import teetime.util.framework.concurrent.queue.ObservableSpScArrayQueue; import teetime.util.framework.concurrent.queue.ObservableSpScArrayQueue;
final class SpScPipe extends AbstractInterThreadPipe implements IMonitorablePipe { final class SpScPipe extends AbstractInterThreadPipe implements IMonitorablePipe {
...@@ -39,16 +40,15 @@ final class SpScPipe extends AbstractInterThreadPipe implements IMonitorablePipe ...@@ -39,16 +40,15 @@ final class SpScPipe extends AbstractInterThreadPipe implements IMonitorablePipe
public boolean add(final Object element) { public boolean add(final Object element) {
while (!this.queue.offer(element)) { while (!this.queue.offer(element)) {
// Thread.yield(); // Thread.yield();
if (this.cachedTargetStage.getCurrentState() == StageState.TERMINATED && if (this.cachedTargetStage.getCurrentState() == StageState.TERMINATED ||
this.getSourcePort().getOwningStage().getCurrentState() == StageState.TERMINATING) { Thread.currentThread().isInterrupted()) {
return false; throw TerminateException.INSTANCE;
} }
this.numWaits++; this.numWaits++;
try { try {
Thread.sleep(1); Thread.sleep(1);
} catch (InterruptedException e) { } catch (InterruptedException e) {
// FIXME Handle it correctly throw TerminateException.INSTANCE;
e.printStackTrace();
} }
} }
// this.reportNewElement(); // this.reportNewElement();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment