Skip to content
Snippets Groups Projects
Commit 4b1583cf authored by Christian Wulf's avatar Christian Wulf
Browse files

removed superfluous dependencies from the pom.xml

parent b51f2b02
No related branches found
No related tags found
No related merge requests found
#FindBugs User Preferences #FindBugs User Preferences
#Tue Apr 21 14:08:24 CEST 2015 #Tue Apr 21 14:15:57 CEST 2015
detector_threshold=3 detector_threshold=3
effort=max effort=max
excludefilter0=.fbExcludeFilterFile|true excludefilter0=.fbExcludeFilterFile|true
......
...@@ -127,12 +127,6 @@ ...@@ -127,12 +127,6 @@
<!-- SNAPSHOT master version --> <!-- SNAPSHOT master version -->
<version>7239659ba0</version> <version>7239659ba0</version>
</dependency> </dependency>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>6.5</version>
</dependency>
<dependency> <dependency>
<groupId>com.carrotsearch</groupId> <groupId>com.carrotsearch</groupId>
...@@ -152,11 +146,6 @@ ...@@ -152,11 +146,6 @@
<format>html</format> <format>html</format>
<format>xml</format> <format>xml</format>
</formats> </formats>
<instrumentation>
<excludes>
<exclude>src/performancetest/**/*</exclude>
</excludes>
</instrumentation>
</configuration> </configuration>
</plugin> </plugin>
<!-- we want JDK 1.6 source and binary compatibility --> <!-- we want JDK 1.6 source and binary compatibility -->
......
/**
* Copyright (C) 2015 Christian Wulf, Nelson Tavares de Sousa (http://teetime.sourceforge.net)
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package qa.cs;
import java.util.HashSet;
import java.util.Set;
import com.puppycrawl.tools.checkstyle.api.Check;
import com.puppycrawl.tools.checkstyle.api.DetailAST;
import com.puppycrawl.tools.checkstyle.api.TokenTypes;
public class PluralForCollectionVariable extends Check {
private final Set<String> collectionNames = new HashSet<String>();
public PluralForCollectionVariable() {
collectionNames.add("Collection");
collectionNames.add("Set");
collectionNames.add("List");
}
@Override
public int[] getDefaultTokens() {
return new int[] { TokenTypes.VARIABLE_DEF };
}
@Override
public void visitToken(final DetailAST ast) {
DetailAST typeAst = ast.findFirstToken(TokenTypes.TYPE);
DetailAST identifierAst = ast.findFirstToken(TokenTypes.IDENT);
DetailAST actualTypeAst = typeAst.getFirstChild();
DetailAST typeArgumentsAst = actualTypeAst.getNextSibling();
String actualTypeName = actualTypeAst.getText();
if (collectionNames.contains(actualTypeName)) {
String identifierName = identifierAst.getText();
if (!identifierName.endsWith("s")) {
String message = "The variable '" + identifierName + "' should be named in plural since it represents a " + actualTypeName + " of "
+ typeArgumentsAst.getText();
log(ast.getLineNo(), message);
}
}
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment