Skip to content
Snippets Groups Projects
Commit 4e9b00b6 authored by Christian Wulf's avatar Christian Wulf
Browse files

Merge branch 'reportUnconnectedPorts' into 'master'

Report unconnected ports

fixes #218
Unconnected ports are now reported

See merge request !53
parents 2ca5a38d 5875ca1a
No related branches found
No related tags found
No related merge requests found
...@@ -19,6 +19,7 @@ import java.util.HashSet; ...@@ -19,6 +19,7 @@ import java.util.HashSet;
import java.util.Set; import java.util.Set;
import teetime.framework.Traverser.VisitorBehavior; import teetime.framework.Traverser.VisitorBehavior;
import teetime.framework.pipe.DummyPipe;
/** /**
* Searches for threadable stages * Searches for threadable stages
...@@ -44,4 +45,10 @@ class A1ThreadableStageCollector implements ITraverserVisitor { ...@@ -44,4 +45,10 @@ class A1ThreadableStageCollector implements ITraverserVisitor {
return VisitorBehavior.CONTINUE; return VisitorBehavior.CONTINUE;
} }
@Override
public void visit(final DummyPipe pipe, final AbstractPort<?> port) {
// TODO Auto-generated method stub
}
} }
...@@ -21,6 +21,7 @@ import com.carrotsearch.hppc.ObjectIntHashMap; ...@@ -21,6 +21,7 @@ import com.carrotsearch.hppc.ObjectIntHashMap;
import com.carrotsearch.hppc.ObjectIntMap; import com.carrotsearch.hppc.ObjectIntMap;
import teetime.framework.Traverser.VisitorBehavior; import teetime.framework.Traverser.VisitorBehavior;
import teetime.framework.pipe.DummyPipe;
import teetime.framework.pipe.IPipe; import teetime.framework.pipe.IPipe;
/** /**
...@@ -90,5 +91,11 @@ public class A2InvalidThreadAssignmentCheck { ...@@ -90,5 +91,11 @@ public class A2InvalidThreadAssignmentCheck {
return VisitorBehavior.STOP; return VisitorBehavior.STOP;
} }
@Override
public void visit(final DummyPipe pipe, final AbstractPort<?> port) {
// TODO Auto-generated method stub
}
} }
} }
...@@ -22,6 +22,7 @@ import org.slf4j.Logger; ...@@ -22,6 +22,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import teetime.framework.Traverser.VisitorBehavior; import teetime.framework.Traverser.VisitorBehavior;
import teetime.framework.pipe.DummyPipe;
import teetime.framework.pipe.IPipe; import teetime.framework.pipe.IPipe;
import teetime.framework.pipe.IPipeFactory; import teetime.framework.pipe.IPipeFactory;
import teetime.framework.pipe.InstantiationPipe; import teetime.framework.pipe.InstantiationPipe;
...@@ -90,4 +91,12 @@ class A3PipeInstantiation implements ITraverserVisitor { ...@@ -90,4 +91,12 @@ class A3PipeInstantiation implements ITraverserVisitor {
} }
} }
@Override
public void visit(final DummyPipe pipe, final AbstractPort<?> port) {
if (LOGGER.isInfoEnabled()) {
LOGGER.info("Unconnected port " + port + " in stage " + port.getOwningStage().getId());
}
}
} }
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
package teetime.framework; package teetime.framework;
import teetime.framework.Traverser.VisitorBehavior; import teetime.framework.Traverser.VisitorBehavior;
import teetime.framework.pipe.DummyPipe;
public interface ITraverserVisitor { public interface ITraverserVisitor {
...@@ -23,4 +24,6 @@ public interface ITraverserVisitor { ...@@ -23,4 +24,6 @@ public interface ITraverserVisitor {
VisitorBehavior visit(AbstractPort<?> port); VisitorBehavior visit(AbstractPort<?> port);
void visit(DummyPipe pipe, AbstractPort<?> port);
} }
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
package teetime.framework; package teetime.framework;
import teetime.framework.Traverser.VisitorBehavior; import teetime.framework.Traverser.VisitorBehavior;
import teetime.framework.pipe.DummyPipe;
public class IntraStageCollector implements ITraverserVisitor { public class IntraStageCollector implements ITraverserVisitor {
...@@ -40,4 +41,10 @@ public class IntraStageCollector implements ITraverserVisitor { ...@@ -40,4 +41,10 @@ public class IntraStageCollector implements ITraverserVisitor {
return VisitorBehavior.CONTINUE; return VisitorBehavior.CONTINUE;
} }
@Override
public void visit(final DummyPipe pipe, final AbstractPort<?> port) {
// TODO Auto-generated method stub
}
} }
...@@ -82,6 +82,7 @@ public class Traverser { ...@@ -82,6 +82,7 @@ public class Traverser {
private void visitAndTraverse(final AbstractPort<?> port, final Direction direction) { private void visitAndTraverse(final AbstractPort<?> port, final Direction direction) {
if (port.getPipe() instanceof DummyPipe) { if (port.getPipe() instanceof DummyPipe) {
traverserVisitor.visit((DummyPipe) port.getPipe(), port);
return; return;
} }
VisitorBehavior behavior = traverserVisitor.visit(port); VisitorBehavior behavior = traverserVisitor.visit(port);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment