Skip to content
Snippets Groups Projects
Commit 8f1dfb66 authored by Nelson Tavares de Sousa's avatar Nelson Tavares de Sousa
Browse files

reduced visibility even more

parent 4fd2bc9e
No related branches found
No related tags found
No related merge requests found
......@@ -210,7 +210,7 @@ public abstract class AbstractStage {
* The port which received the signal
*/
@SuppressWarnings("PMD.DataflowAnomalyAnalysis")
protected final void onSignal(final ISignal signal, final InputPort<?> inputPort) {
final void onSignal(final ISignal signal, final InputPort<?> inputPort) {
Class<? extends ISignal> signalClass = signal.getClass();
Set<InputPort<?>> signalReceivedInputPorts;
......
......@@ -104,84 +104,84 @@ public class AbstractStageTest {
//
//
private Merger<Integer> merger;
private Merger<Integer> arbitraryStage;
private InputPort<Integer> firstPort;
private InputPort<Integer> secondPort;
private MergerTestingPipe mergerOutputPipe;
@Before
public void beforeSignalTesting() {
merger = new Merger<Integer>();
merger.declareActive(); // necessary to initialize the owning thread for onStarting()
arbitraryStage = new Merger<Integer>();
arbitraryStage.declareActive(); // necessary to initialize the owning thread for onStarting()
firstPort = merger.getNewInputPort();
secondPort = merger.getNewInputPort();
firstPort = arbitraryStage.getNewInputPort();
secondPort = arbitraryStage.getNewInputPort();
mergerOutputPipe = new MergerTestingPipe();
merger.getOutputPort().setPipe(mergerOutputPipe);
arbitraryStage.getOutputPort().setPipe(mergerOutputPipe);
}
@Test
public void testSameSignal() {
merger.onSignal(new StartingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), firstPort);
assertTrue(mergerOutputPipe.startSent());
mergerOutputPipe.reset();
merger.onSignal(new StartingSignal(), secondPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), secondPort);
assertFalse(mergerOutputPipe.startSent());
}
@Test
public void testDifferentSignals() {
merger.onSignal(new StartingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), firstPort);
assertTrue(mergerOutputPipe.startSent());
mergerOutputPipe.reset();
merger.onSignal(new TerminatingSignal(), secondPort);
((AbstractStage) arbitraryStage).onSignal(new TerminatingSignal(), secondPort);
assertFalse(mergerOutputPipe.startSent());
}
@Test
public void testInterleavedSignals() {
merger.onSignal(new StartingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), firstPort);
assertTrue(mergerOutputPipe.startSent());
assertFalse(mergerOutputPipe.terminateSent());
mergerOutputPipe.reset();
merger.onSignal(new TerminatingSignal(), secondPort);
((AbstractStage) arbitraryStage).onSignal(new TerminatingSignal(), secondPort);
assertFalse(mergerOutputPipe.startSent());
assertFalse(mergerOutputPipe.terminateSent());
mergerOutputPipe.reset();
merger.onSignal(new TerminatingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new TerminatingSignal(), firstPort);
assertFalse(mergerOutputPipe.startSent());
assertTrue(mergerOutputPipe.terminateSent());
mergerOutputPipe.reset();
merger.onSignal(new TerminatingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new TerminatingSignal(), firstPort);
assertFalse(mergerOutputPipe.startSent());
assertFalse(mergerOutputPipe.terminateSent());
mergerOutputPipe.reset();
merger.onSignal(new StartingSignal(), secondPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), secondPort);
assertFalse(mergerOutputPipe.startSent());
assertFalse(mergerOutputPipe.terminateSent());
}
@Test
public void testMultipleSignals() {
merger.onSignal(new StartingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), firstPort);
assertTrue(mergerOutputPipe.startSent());
mergerOutputPipe.reset();
merger.onSignal(new StartingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), firstPort);
assertFalse(mergerOutputPipe.startSent());
mergerOutputPipe.reset();
merger.onSignal(new StartingSignal(), firstPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), firstPort);
assertFalse(mergerOutputPipe.startSent());
mergerOutputPipe.reset();
merger.onSignal(new StartingSignal(), secondPort);
((AbstractStage) arbitraryStage).onSignal(new StartingSignal(), secondPort);
assertFalse(mergerOutputPipe.startSent());
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment