Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
TeeTime-Framework
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Nelson Tavares de Sousa
TeeTime-Framework
Commits
d12c6d81
Commit
d12c6d81
authored
9 years ago
by
Nelson Tavares de Sousa
Browse files
Options
Downloads
Patches
Plain Diff
not calling the super methods results in an exception
parent
240a6d84
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/main/java/teetime/framework/AbstractStage.java
+19
-1
19 additions, 1 deletion
src/main/java/teetime/framework/AbstractStage.java
src/main/java/teetime/framework/SuperNotCalledException.java
+14
-0
14 additions, 0 deletions
src/main/java/teetime/framework/SuperNotCalledException.java
with
33 additions
and
1 deletion
src/main/java/teetime/framework/AbstractStage.java
+
19
−
1
View file @
d12c6d81
...
...
@@ -31,6 +31,8 @@ import teetime.framework.exceptionHandling.AbstractExceptionListener.FurtherExec
import
teetime.framework.exceptionHandling.TerminateException
;
import
teetime.framework.pipe.IPipe
;
import
teetime.framework.signal.ISignal
;
import
teetime.framework.signal.StartingSignal
;
import
teetime.framework.signal.TerminatingSignal
;
import
teetime.framework.validation.InvalidPortConnection
;
import
teetime.util.framework.port.PortList
;
import
teetime.util.framework.port.PortRemovedListener
;
...
...
@@ -180,6 +182,10 @@ public abstract class AbstractStage {
private
final
PortList
<
InputPort
<?>>
inputPorts
=
new
PortList
<
InputPort
<?>>();
private
final
PortList
<
OutputPort
<?>>
outputPorts
=
new
PortList
<
OutputPort
<?>>();
private
boolean
calledOnTerminating
=
false
;
private
boolean
calledOnStarting
=
false
;
private
volatile
StageState
currentState
=
StageState
.
CREATED
;
protected
List
<
InputPort
<?>>
getInputPorts
()
{
...
...
@@ -216,6 +222,16 @@ public abstract class AbstractStage {
if
(
signal
.
mayBeTriggered
(
signalReceivedInputPorts
,
getInputPorts
()))
{
try
{
signal
.
trigger
(
this
);
if
(
signal
instanceof
StartingSignal
)
{
if
(!
calledOnStarting
)
{
throw
new
SuperNotCalledException
(
"The super method onStarting was not called in "
+
this
.
getId
());
}
}
if
(
signal
instanceof
TerminatingSignal
)
{
if
(!
calledOnTerminating
)
{
throw
new
SuperNotCalledException
(
"The super method onTerminating was not called in "
+
this
.
getId
());
}
}
}
catch
(
Exception
e
)
{
this
.
getOwningContext
().
abortConfigurationRun
();
}
...
...
@@ -248,7 +264,7 @@ public abstract class AbstractStage {
return
signalAlreadyReceived
;
}
private
void
changeState
(
final
StageState
newState
)
{
void
changeState
(
final
StageState
newState
)
{
currentState
=
newState
;
if
(
logger
.
isTraceEnabled
())
{
logger
.
trace
(
newState
.
toString
());
...
...
@@ -270,11 +286,13 @@ public abstract class AbstractStage {
@SuppressWarnings
(
"PMD.SignatureDeclareThrowsException"
)
public
void
onStarting
()
throws
Exception
{
changeState
(
StageState
.
STARTED
);
calledOnStarting
=
true
;
}
@SuppressWarnings
(
"PMD.SignatureDeclareThrowsException"
)
public
void
onTerminating
()
throws
Exception
{
changeState
(
StageState
.
TERMINATED
);
calledOnTerminating
=
true
;
}
/**
...
...
This diff is collapsed.
Click to expand it.
src/main/java/teetime/framework/SuperNotCalledException.java
0 → 100644
+
14
−
0
View file @
d12c6d81
package
teetime.framework
;
public
class
SuperNotCalledException
extends
RuntimeException
{
/**
*
*/
private
static
final
long
serialVersionUID
=
1328934037128066070L
;
SuperNotCalledException
(
final
String
string
)
{
super
(
string
);
}
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment