Merge branch 'checkstyle-solved' into 'master'

Checkstyle solved

Solved a whole bunch of issues regarding checkstyle. For e.g. renamed interfaces to match I[A-Z0-9].* and abstract classes to match Abstract[A-Z0-9].*

See merge request !16

src/main/java/util/BucketTimingsReader.java

@@ -17,29 +17,31 @@ import com.google.common.base.Charsets;
 import com.google.common.io.CharSource;
 import com.google.common.io.Files;
 
-public class BucketTimingsReader {
+public final class BucketTimingsReader {
 
-	private final static Logger LOGGER = LoggerFactory.getLogger(BucketTimingsReader.class);
+	private static final Logger LOGGER = LoggerFactory.getLogger(BucketTimingsReader.class);
+
+	private BucketTimingsReader() {}
 
 	public static void main(final String[] args) throws IOException {
-		String fileName = args[0];
+		final String fileName = args[0];
 
-		Long[] currentTimings = new Long[10000];
+		final Long[] currentTimings = new Long[10000];
 		int processedLines = 0;
-		List<Long> buckets = new LinkedList<Long>();
+		final List<Long> buckets = new LinkedList<Long>();
 
 		LOGGER.trace("Reading " + fileName);
-		CharSource charSource = Files.asCharSource(new File(fileName), Charsets.UTF_8);
-		BufferedReader bufferedStream = charSource.openBufferedStream();
+		final CharSource charSource = Files.asCharSource(new File(fileName), Charsets.UTF_8);
+		final BufferedReader bufferedStream = charSource.openBufferedStream();
 		String line;
 		while (null != (line = bufferedStream.readLine())) {
-			String[] strings = line.split(";");
-			Long timing = new Long(strings[1]);
+			final String[] strings = line.split(";");
+			final Long timing = new Long(strings[1]);
 			currentTimings[processedLines] = timing;
 			processedLines++;
 			if (currentTimings.length == processedLines) {
 				// Long aggregatedTimings = StatisticsUtil.calculateQuintiles(Arrays.asList(currentTimings)).get(0.5);
-				Long aggregatedTimings = StatisticsUtil.calculateAverage(Arrays.asList(currentTimings));
+				final Long aggregatedTimings = StatisticsUtil.calculateAverage(Arrays.asList(currentTimings));
 				buckets.add(aggregatedTimings);
 				processedLines = 0;
 			}
@@ -47,13 +49,13 @@ public class BucketTimingsReader {
 
 		LOGGER.trace("#buckets: " + buckets.size());
 
-		List<Long> durationsInNs = buckets.subList(buckets.size() / 2, buckets.size());
+		final List<Long> durationsInNs = buckets.subList(buckets.size() / 2, buckets.size());
 
 		LOGGER.trace("Calculating quantiles...");
-		Map<Double, Long> quintiles = StatisticsUtil.calculateQuintiles(durationsInNs);
+		final Map<Double, Long> quintiles = StatisticsUtil.calculateQuintiles(durationsInNs);
 		LOGGER.info(StatisticsUtil.getQuantilesString(quintiles));
 
-		long confidenceWidth = StatisticsUtil.calculateConfidenceWidth(durationsInNs);
+		final long confidenceWidth = StatisticsUtil.calculateConfidenceWidth(durationsInNs);
 		LOGGER.info("Confidence width: " + confidenceWidth);
 	}
 }

src/main/java/util/MooBenchStarter.java

@@ -15,7 +15,7 @@ public class MooBenchStarter {
 	}
 
 	public void start(final int runs, final long calls) throws IOException {
-		List<String> command = new LinkedList<String>();
+		final List<String> command = new LinkedList<String>();
 		command.add("cmd");
 		command.add("/c");
 		command.add("start");

src/main/java/util/test/ProfiledPerformanceAssertion.java → src/main/java/util/test/AbstractProfiledPerformanceAssertion.java

 package util.test;
 
-public abstract class ProfiledPerformanceAssertion {
+public abstract class AbstractProfiledPerformanceAssertion {
 
 	public abstract String getCorrespondingPerformanceProfile();
 

src/main/java/util/test/MeasurementRepository.java

@@ -7,6 +7,8 @@ public class MeasurementRepository {
 
 	public final Map<String, PerformanceResult> performanceResults = new HashMap<String, PerformanceResult>();
 
+	public MeasurementRepository() {}
+
 	public static final String buildTestMethodIdentifier(final Class<?> testClass, final String methodName) {
 		return testClass.getName() + "(" + methodName + ")";
 	}

src/main/java/util/test/PerformanceCheckProfileRepository.java

@@ -8,11 +8,11 @@ import org.slf4j.LoggerFactory;
 
 public class PerformanceCheckProfileRepository {
 
-	private static final Logger LOGGER = LoggerFactory.getLogger(PerformanceCheckProfileRepository.class);
-
 	public static final PerformanceCheckProfileRepository INSTANCE = new PerformanceCheckProfileRepository();
 
-	private final Map<Class<?>, ProfiledPerformanceAssertion> performanceCheckProfiles = new HashMap<Class<?>, ProfiledPerformanceAssertion>();
+	private static final Logger LOGGER = LoggerFactory.getLogger(PerformanceCheckProfileRepository.class);
+
+	private final Map<Class<?>, AbstractProfiledPerformanceAssertion> performanceCheckProfiles = new HashMap<Class<?>, AbstractProfiledPerformanceAssertion>();
 
 	private String currentProfile;
 
@@ -29,13 +29,13 @@ public class PerformanceCheckProfileRepository {
 		return this.currentProfile;
 	}
 
-	public void register(final Class<?> testClass, final ProfiledPerformanceAssertion profile) {
+	public void register(final Class<?> testClass, final AbstractProfiledPerformanceAssertion profile) {
 		if (profile.getCorrespondingPerformanceProfile().equals(this.currentProfile)) {
 			this.performanceCheckProfiles.put(testClass, profile);
 		}
 	}
 
-	public ProfiledPerformanceAssertion get(final Class<?> clazz) {
+	public AbstractProfiledPerformanceAssertion get(final Class<?> clazz) {
 		return this.performanceCheckProfiles.get(clazz);
 	}
 }

src/main/java/util/test/PerformanceResult.java

@@ -10,9 +10,11 @@ public class PerformanceResult {
 	public long avgDurInNs;
 	public long confidenceWidthInNs;
 
+	public PerformanceResult() {}
+
 	@Override
 	public String toString() {
-		StringBuilder stringBuilder = new StringBuilder();
+		final StringBuilder stringBuilder = new StringBuilder();
 		stringBuilder.append("overallDurationInNs: ");
 		stringBuilder.append(this.overallDurationInNs);
 		stringBuilder.append("\n");

src/main/java/util/test/StatisticsUtil.java

@@ -42,7 +42,7 @@ public final class StatisticsUtil {
 	}
 
 	public static PerformanceResult computeStatistics(final long overallDurationInNs, final List<TimestampObject> timestampObjects) {
-		PerformanceResult performanceResult = new PerformanceResult();
+		final PerformanceResult performanceResult = new PerformanceResult();
 
 		performanceResult.overallDurationInNs = overallDurationInNs;
 
@@ -71,9 +71,9 @@ public final class StatisticsUtil {
 	}
 
 	public static String getQuantilesString(final Map<Double, Long> quantilesValues) {
-		StringBuilder builder = new StringBuilder();
+		final StringBuilder builder = new StringBuilder();
 		for (final Entry<Double, Long> entry : quantilesValues.entrySet()) {
-			String quantile = (entry.getKey() * 100) + " % : " + TimeUnit.NANOSECONDS.toNanos(entry.getValue()) + " ns";
+			final String quantile = (entry.getKey() * 100) + " % : " + TimeUnit.NANOSECONDS.toNanos(entry.getValue()) + " ns";
 			builder.append(quantile);
 			builder.append("\n");
 		}
@@ -113,7 +113,7 @@ public final class StatisticsUtil {
 	}
 
 	public static void removeLeadingZeroThroughputs(final List<Long> throughputs) {
-		Iterator<Long> iterator = throughputs.iterator();
+		final Iterator<Long> iterator = throughputs.iterator();
 		while (iterator.hasNext()) {
 			if (iterator.next() == 0) {
 				iterator.remove();

src/performancetest/java/teetime/examples/ChwHomeComparisonMethodcallWithPorts.java

@@ -7,9 +7,9 @@ import java.util.Map.Entry;
 
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-public class ChwHomeComparisonMethodcallWithPorts extends ProfiledPerformanceAssertion {
+public class ChwHomeComparisonMethodcallWithPorts extends AbstractProfiledPerformanceAssertion {
 
 	@Override
 	public String getCorrespondingPerformanceProfile() {

src/performancetest/java/teetime/examples/ChwWorkComparisonMethodcallWithPorts.java

@@ -7,9 +7,9 @@ import java.util.Map.Entry;
 
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-public class ChwWorkComparisonMethodcallWithPorts extends ProfiledPerformanceAssertion {
+public class ChwWorkComparisonMethodcallWithPorts extends AbstractProfiledPerformanceAssertion {
 
 	@Override
 	public String getCorrespondingPerformanceProfile() {

src/performancetest/java/teetime/examples/ComparisonMethodcallWithPorts.java

@@ -16,7 +16,7 @@ import teetime.examples.experiment16.MethodCallThoughputTimestampAnalysis16Test;
 import teetime.examples.experiment17.MethodCallThoughputTimestampAnalysis17Test;
 import teetime.examples.experiment19.MethodCallThoughputTimestampAnalysis19Test;
 import util.test.PerformanceCheckProfileRepository;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
 @RunWith(Suite.class)
 @SuiteClasses({
@@ -42,7 +42,7 @@ public class ComparisonMethodcallWithPorts {
 
 	@AfterClass
 	public static void compareResults() {
-		ProfiledPerformanceAssertion pcp = PerformanceCheckProfileRepository.INSTANCE.get(ComparisonMethodcallWithPorts.class);
+		AbstractProfiledPerformanceAssertion pcp = PerformanceCheckProfileRepository.INSTANCE.get(ComparisonMethodcallWithPorts.class);
 		pcp.check();
 	}
 

src/performancetest/java/teetime/examples/NieWorkComparisonMethodcallWithPorts.java

@@ -7,9 +7,9 @@ import java.util.Map.Entry;
 
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-public class NieWorkComparisonMethodcallWithPorts extends ProfiledPerformanceAssertion {
+public class NieWorkComparisonMethodcallWithPorts extends AbstractProfiledPerformanceAssertion {
 
 	@Override
 	public String getCorrespondingPerformanceProfile() {

src/performancetest/java/teetime/examples/experiment01/ChwHomePerformanceCheck.java

@@ -3,9 +3,9 @@ package teetime.examples.experiment01;
 import static org.junit.Assert.assertEquals;
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-class ChwHomePerformanceCheck extends ProfiledPerformanceAssertion {
+class ChwHomePerformanceCheck extends AbstractProfiledPerformanceAssertion {
 
 	@Override
 	public String getCorrespondingPerformanceProfile() {

src/performancetest/java/teetime/examples/experiment01/ChwWorkPerformanceCheck.java

@@ -3,9 +3,9 @@ package teetime.examples.experiment01;
 import static org.junit.Assert.assertEquals;
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-class ChwWorkPerformanceCheck extends ProfiledPerformanceAssertion {
+class ChwWorkPerformanceCheck extends AbstractProfiledPerformanceAssertion {
 
 	@Override
 	public String getCorrespondingPerformanceProfile() {

src/performancetest/java/teetime/examples/experiment01/MethodCallThoughputTimestampAnalysis1Test.java

@@ -23,7 +23,7 @@ import teetime.util.ConstructorClosure;
 import teetime.util.TimestampObject;
 import util.test.PerformanceCheckProfileRepository;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
 /**
  * @author Christian Wulf
@@ -40,7 +40,7 @@ public class MethodCallThoughputTimestampAnalysis1Test extends PerformanceTest {
 
 	@AfterClass
 	public static void afterClass() {
-		ProfiledPerformanceAssertion performanceCheckProfile = PerformanceCheckProfileRepository.INSTANCE.get(MethodCallThoughputTimestampAnalysis1Test.class);
+		AbstractProfiledPerformanceAssertion performanceCheckProfile = PerformanceCheckProfileRepository.INSTANCE.get(MethodCallThoughputTimestampAnalysis1Test.class);
 		performanceCheckProfile.check();
 	};
 

src/performancetest/java/teetime/examples/experiment09/AbstractPerformanceCheck.java

@@ -4,9 +4,9 @@ import teetime.examples.experiment01.MethodCallThoughputTimestampAnalysis1Test;
 import util.test.MeasurementRepository;
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-abstract class AbstractPerformanceCheck extends ProfiledPerformanceAssertion {
+abstract class AbstractPerformanceCheck extends AbstractProfiledPerformanceAssertion {
 
 	protected PerformanceResult test01;
 	protected PerformanceResult test09;

src/performancetest/java/teetime/examples/experiment09/MethodCallThoughputTimestampAnalysis9Test.java

@@ -22,7 +22,7 @@ import org.junit.Test;
 import teetime.util.ConstructorClosure;
 import teetime.util.TimestampObject;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
 /**
  * @author Christian Wulf
@@ -39,7 +39,7 @@ public class MethodCallThoughputTimestampAnalysis9Test extends PerformanceTest {
 
 	@AfterClass
 	public static void afterClass() {
-		ProfiledPerformanceAssertion performanceCheckProfile = PERFORMANCE_CHECK_PROFILE_REPOSITORY.get(MethodCallThoughputTimestampAnalysis9Test.class);
+		AbstractProfiledPerformanceAssertion performanceCheckProfile = PERFORMANCE_CHECK_PROFILE_REPOSITORY.get(MethodCallThoughputTimestampAnalysis9Test.class);
 		performanceCheckProfile.check();
 	};
 

src/performancetest/java/teetime/examples/experiment09/MethodCallThroughputAnalysis9.java

@@ -19,7 +19,7 @@ import java.util.List;
 
 import teetime.framework.OldHeadPipeline;
 import teetime.framework.RunnableStage;
-import teetime.framework.Stage;
+import teetime.framework.IStage;
 import teetime.framework.pipe.CommittablePipe;
 import teetime.stage.CollectorSink;
 import teetime.stage.NoopFilter;
@@ -43,7 +43,7 @@ public class MethodCallThroughputAnalysis9 {
 	private Runnable runnable;
 
 	public void init() {
-		Stage pipeline = this.buildPipeline();
+		IStage pipeline = this.buildPipeline();
 		this.runnable = new RunnableStage(pipeline);
 	}
 

src/performancetest/java/teetime/examples/experiment10/AbstractPerformanceCheck.java

@@ -4,9 +4,9 @@ import teetime.examples.experiment01.MethodCallThoughputTimestampAnalysis1Test;
 import util.test.MeasurementRepository;
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-abstract class AbstractPerformanceCheck extends ProfiledPerformanceAssertion {
+abstract class AbstractPerformanceCheck extends AbstractProfiledPerformanceAssertion {
 
 	protected PerformanceResult test01;
 	protected PerformanceResult test10;

src/performancetest/java/teetime/examples/experiment10/MethodCallThoughputTimestampAnalysis10Test.java

@@ -22,7 +22,7 @@ import org.junit.Test;
 import teetime.util.ConstructorClosure;
 import teetime.util.TimestampObject;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
 /**
  * @author Christian Wulf
@@ -39,7 +39,7 @@ public class MethodCallThoughputTimestampAnalysis10Test extends PerformanceTest
 
 	@AfterClass
 	public static void afterClass() {
-		ProfiledPerformanceAssertion performanceCheckProfile = PERFORMANCE_CHECK_PROFILE_REPOSITORY.get(MethodCallThoughputTimestampAnalysis10Test.class);
+		AbstractProfiledPerformanceAssertion performanceCheckProfile = PERFORMANCE_CHECK_PROFILE_REPOSITORY.get(MethodCallThoughputTimestampAnalysis10Test.class);
 		performanceCheckProfile.check();
 	};
 

src/performancetest/java/teetime/examples/experiment11/ChwHomePerformanceCheck.java

@@ -3,9 +3,9 @@ package teetime.examples.experiment11;
 import static org.junit.Assert.assertEquals;
 import util.test.PerformanceResult;
 import util.test.PerformanceTest;
-import util.test.ProfiledPerformanceAssertion;
+import util.test.AbstractProfiledPerformanceAssertion;
 
-class ChwHomePerformanceCheck extends ProfiledPerformanceAssertion {
+class ChwHomePerformanceCheck extends AbstractProfiledPerformanceAssertion {
 
 	@Override
 	public String getCorrespondingPerformanceProfile() {