Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
TeeTime-Framework
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Nelson Tavares de Sousa
TeeTime-Framework
Commits
f469e582
Commit
f469e582
authored
9 years ago
by
Christian Wulf
Browse files
Options
Downloads
Patches
Plain Diff
moved checkstyle rule
parent
ea2b5cd8
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
conf/quality-config/cs-conf.xml
+2
-13
2 additions, 13 deletions
conf/quality-config/cs-conf.xml
pom.xml
+23
-23
23 additions, 23 deletions
pom.xml
src/test/java/qa/cs/PluralForCollectionVariable.java
+3
-3
3 additions, 3 deletions
src/test/java/qa/cs/PluralForCollectionVariable.java
with
28 additions
and
39 deletions
conf/quality-config/cs-conf.xml
+
2
−
13
View file @
f469e582
...
...
@@ -465,7 +465,7 @@
<!-- Ensures that the setUp(), tearDown()methods are named correctly, have no arguments, !-->
<!-- return void and are either public or protected. !-->
<!-- See http://checkstyle.sf.net/config_coding.html !-->
<module
name=
"JUnitTestCase"
/>
<!--
<module name="JUnitTestCase"/>
-->
<!-- Checks that there are no "magic numbers", where a magic number is a numeric literal !-->
<!-- that is not defined as a constant. !-->
...
...
@@ -537,23 +537,12 @@
<!-- Ensure a class has a package declaration. !-->
<!-- See http://checkstyle.sf.net/config_coding.html !-->
<module
name=
"PackageDeclaration"
>
<property
name=
"ignoreDirectoryName"
value=
"false"
/>
</module>
<!-- Disallow assignment of parameters. !-->
<!-- See http://checkstyle.sf.net/config_coding.html !-->
<module
name=
"ParameterAssignment"
/>
<!-- Checks for redundant exceptions declared in throws clause such as duplicates, !-->
<!-- unchecked exceptions or subclasses of another declared exception. !-->
<!-- See http://checkstyle.sf.net/config_coding.html !-->
<module
name=
"RedundantThrows"
>
<property
name=
"allowUnchecked"
value=
"true"
/>
<property
name=
"allowSubclasses"
value=
"false"
/>
<property
name=
"logLoadErrors"
value=
"true"
/>
<property
name=
"suppressLoadErrors"
value=
"false"
/>
</module>
<!-- Checks that code doesn't rely on the "this." default. !-->
<!-- See http://checkstyle.sf.net/config_coding.html !-->
<module
name=
"RequireThis"
>
...
...
@@ -1211,7 +1200,7 @@
<property
name=
"allowEmptyMethods"
value=
"true"
/>
</module>
<module
name=
"qa.PluralForCollectionVariable
Check
"
/>
<module
name=
"qa.
cs.
PluralForCollectionVariable"
/>
</module>
...
...
This diff is collapsed.
Click to expand it.
pom.xml
+
23
−
23
View file @
f469e582
...
...
@@ -223,29 +223,29 @@
</configuration>
</plugin>
<!--
Checkstyle -->
<plugin>
<groupId>
org.apache.maven.plugins
</groupId>
<artifactId>
maven-checkstyle-plugin
</artifactId>
<version>
2.1
2
</version>
<executions>
<execution>
<phase>
test
</phase>
<goals>
<goal>
check
</goal>
</goals>
<configuration>
<configLocation>
${project.basedir}/conf/quality-config/cs-conf.xml
</configLocation>
<includeTestSourceDirectory>
true
</includeTestSourceDirectory>
<encoding>
UTF-8
</encoding>
<consoleOutput>
true
</consoleOutput>
<failsOnError>
false
</failsOnError>
<failOnViolation>
false
</failOnViolation>
<linkXRef>
false
</linkXRef>
</configuration>
</execution>
</executions>
</plugin>
<!-- Checkstyle -->
<!--
<plugin>
-->
<!--
<groupId>org.apache.maven.plugins</groupId>
-->
<!--
<artifactId>maven-checkstyle-plugin</artifactId>
-->
<!--
<version>2.1
5
</version>
-->
<!--
<executions>
-->
<!--
<execution>
-->
<!--
<phase>test</phase>
-->
<!--
<goals>
-->
<!--
<goal>check</goal>
-->
<!--
</goals>
-->
<!--
<configuration>
-->
<!--
<configLocation>${project.basedir}/conf/quality-config/cs-conf.xml</configLocation>
-->
<!--
<includeTestSourceDirectory>true</includeTestSourceDirectory>
-->
<!--
<encoding>UTF-8</encoding>
-->
<!--
<consoleOutput>true</consoleOutput>
-->
<!--
<failsOnError>false</failsOnError>
-->
<!--
<failOnViolation>false</failOnViolation>
-->
<!--
<linkXRef>false</linkXRef>
-->
<!--
</configuration>
-->
<!--
</execution>
-->
<!--
</executions>
-->
<!--
</plugin>
-->
<!-- Findbugs -->
<plugin>
...
...
This diff is collapsed.
Click to expand it.
src/test/java/qa/PluralForCollectionVariable
Check
.java
→
src/test/java/qa/
cs/
PluralForCollectionVariable.java
+
3
−
3
View file @
f469e582
...
...
@@ -13,7 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package
qa
;
package
qa
.cs
;
import
java.util.HashSet
;
import
java.util.Set
;
...
...
@@ -22,11 +22,11 @@ import com.puppycrawl.tools.checkstyle.api.Check;
import
com.puppycrawl.tools.checkstyle.api.DetailAST
;
import
com.puppycrawl.tools.checkstyle.api.TokenTypes
;
public
class
PluralForCollectionVariable
Check
extends
Check
{
public
class
PluralForCollectionVariable
extends
Check
{
private
final
Set
<
String
>
collectionNames
=
new
HashSet
<
String
>();
public
PluralForCollectionVariable
Check
()
{
public
PluralForCollectionVariable
()
{
collectionNames
.
add
(
"Collection"
);
collectionNames
.
add
(
"Set"
);
collectionNames
.
add
(
"List"
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment