Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
TeeTime-Framework
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Nelson Tavares de Sousa
TeeTime-Framework
Commits
f4e2e84a
Commit
f4e2e84a
authored
9 years ago
by
Christian Wulf
Browse files
Options
Downloads
Patches
Plain Diff
deactivated PMD's UR anomaly rule
parent
8d089dd8
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
conf/quality-config/pmd-ruleset.xml
+8
-0
8 additions, 0 deletions
conf/quality-config/pmd-ruleset.xml
src/main/java/teetime/framework/ExecutionInstantiation.java
+1
-4
1 addition, 4 deletions
src/main/java/teetime/framework/ExecutionInstantiation.java
with
9 additions
and
4 deletions
conf/quality-config/pmd-ruleset.xml
+
8
−
0
View file @
f4e2e84a
...
@@ -65,6 +65,14 @@
...
@@ -65,6 +65,14 @@
<exclude
name=
"AvoidUsingVolatile"
/>
<exclude
name=
"AvoidUsingVolatile"
/>
</rule>
</rule>
<!-- UR means "undefined reference" which is already detected by the compiler.
so we deactivate it. -->
<rule
ref=
"rulesets/java/controversial.xml/DataflowAnomalyAnalysis"
>
<properties>
<property
name=
"violationSuppressRegex"
value=
"^Found 'UR'-anomaly.*"
/>
</properties>
</rule>
<rule
ref=
"rulesets/java/coupling.xml"
>
<rule
ref=
"rulesets/java/coupling.xml"
>
<exclude
name=
"LawOfDemeter"
/>
<exclude
name=
"LawOfDemeter"
/>
</rule>
</rule>
...
...
This diff is collapsed.
Click to expand it.
src/main/java/teetime/framework/ExecutionInstantiation.java
+
1
−
4
View file @
f4e2e84a
...
@@ -66,10 +66,7 @@ class ExecutionInstantiation {
...
@@ -66,10 +66,7 @@ class ExecutionInstantiation {
final
OutputPort
outputPort
,
final
InstantiationPipe
pipe
)
{
final
OutputPort
outputPort
,
final
InstantiationPipe
pipe
)
{
Stage
targetStage
=
pipe
.
getTargetPort
().
getOwningStage
();
Stage
targetStage
=
pipe
.
getTargetPort
().
getOwningStage
();
int
targetColor
=
DEFAULT_COLOR
;
int
targetColor
=
colors
.
containsKey
(
targetStage
)
?
colors
.
get
(
targetStage
)
:
DEFAULT_COLOR
;
if
(
colors
.
containsKey
(
targetStage
))
{
targetColor
=
colors
.
get
(
targetStage
);
}
if
(
threadableStages
.
contains
(
targetStage
)
&&
targetColor
!=
color
)
{
if
(
threadableStages
.
contains
(
targetStage
)
&&
targetColor
!=
color
)
{
if
(
pipe
.
capacity
()
!=
0
)
{
if
(
pipe
.
capacity
()
!=
0
)
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment