Skip to content
Snippets Groups Projects
Commit 09e71578 authored by Lorenz Boguhn's avatar Lorenz Boguhn
Browse files

Clear code style problems + doku

parent 4a835853
No related branches found
No related tags found
1 merge request!208Add benchmark implementations for Hazelcast Jet
Pipeline #7269 passed
...@@ -8,6 +8,11 @@ import org.apache.kafka.clients.consumer.ConsumerConfig; ...@@ -8,6 +8,11 @@ import org.apache.kafka.clients.consumer.ConsumerConfig;
import org.apache.kafka.clients.producer.ProducerConfig; import org.apache.kafka.clients.producer.ProducerConfig;
/**
* Generalized builder for Kafka properties.
* Will always set AUTO_OFFSET_RESET_CONFIG to earliest
*
*/
public class KafkaPropertiesBuilder { public class KafkaPropertiesBuilder {
private static final String TRUE = "true"; private static final String TRUE = "true";
...@@ -19,9 +24,12 @@ public class KafkaPropertiesBuilder { ...@@ -19,9 +24,12 @@ public class KafkaPropertiesBuilder {
* *
* @param kafkaBootstrapServerDefault Default bootstrap server if not set by environment. * @param kafkaBootstrapServerDefault Default bootstrap server if not set by environment.
* @param schemaRegistryUrlDefault Default schema registry URL if not set by environment. * @param schemaRegistryUrlDefault Default schema registry URL if not set by environment.
* @param applicationName Used to set the group id to commit the offsets
* @param keyDeserializer Classname for the key deserializer.
* @param valueDeserializer Classname for the value deserializer.
* @return A Kafka Properties Object containing the values needed for a Pipeline. * @return A Kafka Properties Object containing the values needed for a Pipeline.
*/ */
public Properties buildKafkaInputReadPropsFromEnv(final String kafkaBootstrapServerDefault, public Properties buildKafkaInputReadPropsFromEnv(final String kafkaBootstrapServerDefault,//NOPMD
final String schemaRegistryUrlDefault, final String schemaRegistryUrlDefault,
final String applicationName, final String applicationName,
final String keyDeserializer, final String keyDeserializer,
...@@ -54,10 +62,13 @@ public class KafkaPropertiesBuilder { ...@@ -54,10 +62,13 @@ public class KafkaPropertiesBuilder {
* Builds Kafka Properties used for the UC4 Benchmark pipeline. * Builds Kafka Properties used for the UC4 Benchmark pipeline.
* *
* @param kafkaBootstrapServerDefault Default bootstrap server if not set by environment. * @param kafkaBootstrapServerDefault Default bootstrap server if not set by environment.
* @param schemaRegistryUrlDefault Default schema registry URL if not set by environment.
* @param keySerializer Classname for the key serializer.
* @param valueSerializer Classname for the value serializer.
* @return A Kafka Properties Object containing the values needed for a Hazelcast Jet UC4 * @return A Kafka Properties Object containing the values needed for a Hazelcast Jet UC4
* Pipeline. * Pipeline.
*/ */
public Properties buildKafkaWritePropsFromEnv(final String kafkaBootstrapServerDefault, public Properties buildKafkaWritePropsFromEnv(final String kafkaBootstrapServerDefault,//NOPMD
final String schemaRegistryUrlDefault, final String schemaRegistryUrlDefault,
final String keySerializer, final String keySerializer,
final String valueSerializer) { final String valueSerializer) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment