Skip to content
Snippets Groups Projects
Commit ca558640 authored by Sören Henning's avatar Sören Henning
Browse files

Further improvements of code quality

parent 6c7252f7
No related branches found
No related tags found
1 merge request!90Migrate Flink benchmark implementation
Pipeline #2218 failed
...@@ -155,7 +155,7 @@ public class HistoryServiceFlinkJob { ...@@ -155,7 +155,7 @@ public class HistoryServiceFlinkJob {
final String newKey = keyFactory.getSensorId(tuple.f0); final String newKey = keyFactory.getSensorId(tuple.f0);
final String newValue = tuple.f1.toString(); final String newValue = tuple.f1.toString();
final int hourOfDay = tuple.f0.getHourOfDay(); final int hourOfDay = tuple.f0.getHourOfDay();
LOGGER.info(newKey + "|" + hourOfDay + ": " + newValue); LOGGER.info("{}|{}: {}", newKey, hourOfDay, newValue);
return new Tuple2<>(newKey, newValue); return new Tuple2<>(newKey, newValue);
} }
}).name("map") }).name("map")
......
...@@ -32,15 +32,19 @@ public class HourOfDayKey { ...@@ -32,15 +32,19 @@ public class HourOfDayKey {
@Override @Override
public int hashCode() { public int hashCode() {
return Objects.hash(hourOfDay, sensorId); return Objects.hash(this.hourOfDay, this.sensorId);
} }
@Override @Override
public boolean equals(Object obj) { public boolean equals(final Object obj) {
if (obj == this) return true; if (obj == this) {
if (!(obj instanceof HourOfDayKey)) return false; return true;
}
if (!(obj instanceof HourOfDayKey)) {
return false;
}
final HourOfDayKey k = (HourOfDayKey) obj; final HourOfDayKey k = (HourOfDayKey) obj;
return hourOfDay == k.hourOfDay && sensorId.equals(k.sensorId); return this.hourOfDay == k.hourOfDay && this.sensorId.equals(k.sensorId);
} }
public byte[] toByteArray() { public byte[] toByteArray() {
......
...@@ -4,19 +4,19 @@ import com.esotericsoftware.kryo.Kryo; ...@@ -4,19 +4,19 @@ import com.esotericsoftware.kryo.Kryo;
import com.esotericsoftware.kryo.Serializer; import com.esotericsoftware.kryo.Serializer;
import com.esotericsoftware.kryo.io.Input; import com.esotericsoftware.kryo.io.Input;
import com.esotericsoftware.kryo.io.Output; import com.esotericsoftware.kryo.io.Output;
import java.io.Serializable;
import org.apache.kafka.common.serialization.Serde; import org.apache.kafka.common.serialization.Serde;
import titan.ccp.common.kafka.simpleserdes.BufferSerde; import titan.ccp.common.kafka.simpleserdes.BufferSerde;
import titan.ccp.common.kafka.simpleserdes.ReadBuffer; import titan.ccp.common.kafka.simpleserdes.ReadBuffer;
import titan.ccp.common.kafka.simpleserdes.SimpleSerdes; import titan.ccp.common.kafka.simpleserdes.SimpleSerdes;
import titan.ccp.common.kafka.simpleserdes.WriteBuffer; import titan.ccp.common.kafka.simpleserdes.WriteBuffer;
import java.io.Serializable;
/** /**
* {@link BufferSerde} for a {@link HourOfDayKey}. Use the {@link #create()} method to create a new * {@link BufferSerde} for a {@link HourOfDayKey}. Use the {@link #create()} method to create a new
* Kafka {@link Serde}. * Kafka {@link Serde}.
*/ */
public class HourOfDayKeySerde extends Serializer<HourOfDayKey> implements BufferSerde<HourOfDayKey>, Serializable { public class HourOfDayKeySerde extends Serializer<HourOfDayKey>
implements BufferSerde<HourOfDayKey>, Serializable {
@Override @Override
public void serialize(final WriteBuffer buffer, final HourOfDayKey data) { public void serialize(final WriteBuffer buffer, final HourOfDayKey data) {
...@@ -36,14 +36,14 @@ public class HourOfDayKeySerde extends Serializer<HourOfDayKey> implements Buffe ...@@ -36,14 +36,14 @@ public class HourOfDayKeySerde extends Serializer<HourOfDayKey> implements Buffe
} }
@Override @Override
public void write(Kryo kryo, Output output, HourOfDayKey object) { public void write(final Kryo kryo, final Output output, final HourOfDayKey object) {
byte[] data = object.toByteArray(); final byte[] data = object.toByteArray();
output.writeInt(data.length); output.writeInt(data.length);
output.writeBytes(data); output.writeBytes(data);
} }
@Override @Override
public HourOfDayKey read(Kryo kryo, Input input, Class<HourOfDayKey> type) { public HourOfDayKey read(final Kryo kryo, final Input input, final Class<HourOfDayKey> type) {
final int numBytes = input.readInt(); final int numBytes = input.readInt();
return HourOfDayKey.fromByteArray(input.readBytes(numBytes)); return HourOfDayKey.fromByteArray(input.readBytes(numBytes));
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment