Skip to content

Enhance Code Quality

Benedikt Wetzel requested to merge wetzel/spesb:enhance-code-quality into master

This MR aims to improve code quality, it includes refactoring and restructuring and code formatting. In particular, it includes:

  • Copying the examples folder to the Docker images, this makes it possible to use the examples as default execution and benchmark even in standalone mode
  • Renaming TheodoliteYamlExecutor to TheodoliteStandalone
  • Replace KafkaLagExporterRemover with ResourceByLabelHandler. This handler encapsulates all requests to Kubernetes resources via labels
  • Replace fabric8 DefaultKubernetesClient with NamespacedKubernetesClient, this way we can simplify some calls (inNamespace() can be removed)
  • Extract the code for adding an additional label patcher from TheodoliteController into a new class ConfigOverrideModifier. Add test for this ConfigOverrideModifier
  • Extract the State Comperator from TheodoliteController into a new class ExecutionComparator
  • Add ImagePatcher to the PatcherFactory
  • Some minor code changes, like changing the type of exceptions, code formatting or cleanup, updating KDoc

Closes #209 (closed)

Edited by Sören Henning

Merge request reports