Skip to content
Snippets Groups Projects
Commit 1b54bf3d authored by Nils Christian Ehmke's avatar Nils Christian Ehmke
Browse files

FB and PMD issues

parent cd0f8c4b
No related branches found
No related tags found
No related merge requests found
......@@ -16,7 +16,7 @@
package kieker.gui.common.domain;
public abstract class AbstractTrace {
public abstract class AbstractTrace { // NOPMD (abstract class without abstract methods)
private final OperationCall rootOperationCall;
......
......@@ -21,7 +21,7 @@ import java.util.EnumMap;
import java.util.List;
import java.util.Map;
public final class OperationCall {
public final class OperationCall { // NOPMD (cyclomatic complexity)
private final Map<StatisticType, Object> statistics = new EnumMap<>(StatisticType.class);
private final List<OperationCall> children = new ArrayList<>();
......
......@@ -47,7 +47,7 @@ public final class AggregatedTraceStatisticsDecorator extends AbstractStage<Aggr
}
}
private final class TraceDurationVisitor {
private static final class TraceDurationVisitor {
private final List<List<Long>> durationsPerEdge = new ArrayList<>();
private int edgeIndex;
......
......@@ -43,7 +43,7 @@ public final class TraceAggregator extends AbstractStage<Trace, AggregatedTrace>
}
@Override
public void onTerminating() throws Exception {
public void onTerminating() throws Exception { // NOPMD (the throws clause is forced by the framework)
for (final List<Trace> aggregationList : this.aggregationMap.values()) {
final AggregatedTrace aggregatedTrace = new AggregatedTrace(aggregationList);
super.send(aggregatedTrace);
......
......@@ -14,7 +14,7 @@
* limitations under the License.
***************************************************************************/
package kieker.gui.subview.traces;
package kieker.gui.subview.traces; // NOPMD (to many imports)
import java.util.List;
import java.util.Observable;
......@@ -328,7 +328,7 @@ public final class View implements Observer, ISubView {
}
final String duration = (Long.toString(operationCall.getDuration()) + " " + View.this.model.getShortTimeUnit()).trim();
item.setText(new String[] { operationCall.getContainer(), componentName, operationString, duration,
String.format("%.1f%%", (float) operationCall.getStatistic(StatisticType.PERCENT)), traceID });
String.format("%.1f%%", operationCall.getStatistic(StatisticType.PERCENT)), traceID });
if (operationCall.isFailed()) {
final Color colorRed = Display.getCurrent().getSystemColor(SWT.COLOR_RED);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment