Skip to content
Snippets Groups Projects
Commit a60eacfd authored by Christian Wulf's avatar Christian Wulf
Browse files

fixed PMD issues

parent 8d7ef48e
No related branches found
No related tags found
No related merge requests found
...@@ -14,7 +14,8 @@ import teetime.framework.validation.InvalidPortConnection; ...@@ -14,7 +14,8 @@ import teetime.framework.validation.InvalidPortConnection;
* Represents a minimal Stage, with some pre-defined methods. * Represents a minimal Stage, with some pre-defined methods.
* Implemented stages need to adapt all abstract methods with own implementations. * Implemented stages need to adapt all abstract methods with own implementations.
*/ */
public abstract class Stage { // NOPMD (should not start with "Abstract") @SuppressWarnings("PMD.AbstractNaming")
public abstract class Stage {
private static final ConcurrentMap<String, Integer> INSTANCES_COUNTER = new ConcurrentHashMap<String, Integer>(); private static final ConcurrentMap<String, Integer> INSTANCES_COUNTER = new ConcurrentHashMap<String, Integer>();
...@@ -22,6 +23,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract") ...@@ -22,6 +23,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract")
/** /**
* A unique logger instance per stage instance * A unique logger instance per stage instance
*/ */
@SuppressWarnings("PMD.LoggerIsNotStaticFinal")
protected final Logger logger; protected final Logger logger;
protected Stage() { protected Stage() {
...@@ -30,9 +32,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract") ...@@ -30,9 +32,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract")
} }
/** /**
* Retrieves the identifier associated with the stage * @return an identifier that is unique among all stage instances. It is especially unique among all instances of the same stage type.
*
* @return An id as String
*/ */
public String getId() { public String getId() {
return this.id; return this.id;
...@@ -56,6 +56,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract") ...@@ -56,6 +56,7 @@ public abstract class Stage { // NOPMD (should not start with "Abstract")
return newId; return newId;
} }
@SuppressWarnings("PMD.DefaultPackage")
static void clearInstanceCounters() { static void clearInstanceCounters() {
INSTANCES_COUNTER.clear(); INSTANCES_COUNTER.clear();
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment