Skip to content
Snippets Groups Projects
Commit f97a6040 authored by Christian Wulf's avatar Christian Wulf
Browse files

added comments;

added finals
parent 42c0d361
No related branches found
No related tags found
No related merge requests found
...@@ -28,7 +28,7 @@ public abstract class AbstractInterThreadPipe extends AbstractPipe { ...@@ -28,7 +28,7 @@ public abstract class AbstractInterThreadPipe extends AbstractPipe {
} }
} }
protected boolean isThreadWaiting(final Thread thread) { protected final boolean isThreadWaiting(final Thread thread) {
return thread.getState() == State.WAITING || thread.getState() == State.TIMED_WAITING; return thread.getState() == State.WAITING || thread.getState() == State.TIMED_WAITING;
} }
......
...@@ -10,9 +10,8 @@ public abstract class AbstractIntraThreadPipe extends AbstractPipe { ...@@ -10,9 +10,8 @@ public abstract class AbstractIntraThreadPipe extends AbstractPipe {
@Override @Override
public final void sendSignal(final ISignal signal) { public final void sendSignal(final ISignal signal) {
// if (this.getTargetPort() != null) { // BETTER remove this check since there are DummyPorts // getTargetPort is always non-null since the framework adds dummy ports if necessary
this.cachedTargetStage.onSignal(signal, this.getTargetPort()); this.cachedTargetStage.onSignal(signal, this.getTargetPort());
// }
} }
@Override @Override
......
...@@ -11,6 +11,12 @@ final class RunnableConsumerStage extends RunnableStage { ...@@ -11,6 +11,12 @@ final class RunnableConsumerStage extends RunnableStage {
private final IdleStrategy idleStrategy; private final IdleStrategy idleStrategy;
/**
* Creates a new instance with the {@link YieldStrategy} as default idle strategy.
*
* @param stage
* to execute within an own thread
*/
public RunnableConsumerStage(final Stage stage) { public RunnableConsumerStage(final Stage stage) {
this(stage, new YieldStrategy()); this(stage, new YieldStrategy());
} }
......
...@@ -34,7 +34,7 @@ class ChwHomePerformanceCheck extends AbstractPerformanceCheck { ...@@ -34,7 +34,7 @@ class ChwHomePerformanceCheck extends AbstractPerformanceCheck {
// since 31.08.2014 (incl.) // since 31.08.2014 (incl.)
// assertEquals(44, medianSpeedup, 2.1); // +2 // assertEquals(44, medianSpeedup, 2.1); // +2
// since 04.11.2014 (incl.) // since 04.11.2014 (incl.)
// assertEquals(71, medianSpeedup, 2.1); // +33 // assertEquals(71, medianSpeedup, 2.1); // +27
// since 05.12.2014 (incl.) // since 05.12.2014 (incl.)
// assertEquals(45, medianSpeedup, 2.1); // -26 // assertEquals(45, medianSpeedup, 2.1); // -26
// since 28.12.2014 (incl.) // since 28.12.2014 (incl.)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment