Skip to content
Snippets Groups Projects
Commit bc1d0334 authored by Nils Christian Ehmke's avatar Nils Christian Ehmke
Browse files

Checkstyle issues

parent 29b91d07
No related branches found
No related tags found
No related merge requests found
...@@ -25,6 +25,8 @@ import kieker.gui.mainview.Controller; ...@@ -25,6 +25,8 @@ import kieker.gui.mainview.Controller;
*/ */
public final class Main { public final class Main {
private Main() {}
/** /**
* The main method of this application. * The main method of this application.
* *
......
...@@ -83,9 +83,6 @@ public final class Execution extends AbstractExecution<Execution> { ...@@ -83,9 +83,6 @@ public final class Execution extends AbstractExecution<Execution> {
if (this == other) { if (this == other) {
return true; return true;
} }
if (other == null) {
return false;
}
if (!(other instanceof Execution)) { if (!(other instanceof Execution)) {
return false; return false;
} }
......
...@@ -57,7 +57,8 @@ public final class ImportAnalysisConfiguration extends AnalysisConfiguration { ...@@ -57,7 +57,8 @@ public final class ImportAnalysisConfiguration extends AnalysisConfiguration {
final ReadingComposite reader = new ReadingComposite(importDirectory); final ReadingComposite reader = new ReadingComposite(importDirectory);
final MultipleInstanceOfFilter<IMonitoringRecord> typeFilter = new MultipleInstanceOfFilter<>(); final MultipleInstanceOfFilter<IMonitoringRecord> typeFilter = new MultipleInstanceOfFilter<>();
final TraceReconstructionComposite traceReconstruction = new TraceReconstructionComposite(this.traces, this.failedTraces, this.failureContainingTraces); final TraceReconstructionComposite traceReconstruction = new TraceReconstructionComposite(this.traces, this.failedTraces, this.failureContainingTraces);
final TraceAggregationComposite traceAggregation = new TraceAggregationComposite(this.aggregatedTraces, this.failedAggregatedTraces, this.failureContainingAggregatedTraces); final TraceAggregationComposite traceAggregation = new TraceAggregationComposite(this.aggregatedTraces, this.failedAggregatedTraces,
this.failureContainingAggregatedTraces);
final CollectorSink<KiekerMetadataRecord> metadataCollector = new CollectorSink<>(this.metadataRecords); final CollectorSink<KiekerMetadataRecord> metadataCollector = new CollectorSink<>(this.metadataRecords);
......
...@@ -44,7 +44,8 @@ public final class TraceAggregationComposite extends Stage { ...@@ -44,7 +44,8 @@ public final class TraceAggregationComposite extends Stage {
private final CollectorSink<AggregatedExecution> failedTracesCollector; private final CollectorSink<AggregatedExecution> failedTracesCollector;
private final CollectorSink<AggregatedExecution> failureContainingTracesCollector; private final CollectorSink<AggregatedExecution> failureContainingTracesCollector;
public TraceAggregationComposite(final List<AggregatedExecution> traces, final List<AggregatedExecution> failedTraces, final List<AggregatedExecution> failureContainingTraces) { public TraceAggregationComposite(final List<AggregatedExecution> traces, final List<AggregatedExecution> failedTraces,
final List<AggregatedExecution> failureContainingTraces) {
this.aggregator = new TraceAggregator(); this.aggregator = new TraceAggregator();
this.distributor = new Distributor<>(new CopyByReferenceStrategy()); this.distributor = new Distributor<>(new CopyByReferenceStrategy());
this.failedTraceFilter = new FailedTraceFilter<>(); this.failedTraceFilter = new FailedTraceFilter<>();
......
...@@ -147,7 +147,8 @@ public final class Controller implements SelectionListener { ...@@ -147,7 +147,8 @@ public final class Controller implements SelectionListener {
} }
public enum SubView { public enum SubView {
TRACES_SUB_VIEW, FAILED_TRACES_SUB_VIEW, AGGREGATED_TRACES_SUB_VIEW, NONE, FAILURE_CONTAINING_TRACES_SUB_VIEW, FAILED_AGGREGATED_TRACES_SUB_VIEW, FAILURE_CONTAINING_AGGREGATED_TRACES_SUB_VIEW TRACES_SUB_VIEW, FAILED_TRACES_SUB_VIEW, AGGREGATED_TRACES_SUB_VIEW, NONE, FAILURE_CONTAINING_TRACES_SUB_VIEW, FAILED_AGGREGATED_TRACES_SUB_VIEW,
FAILURE_CONTAINING_AGGREGATED_TRACES_SUB_VIEW
} }
} }
...@@ -29,7 +29,7 @@ import kieker.gui.subview.util.IModel; ...@@ -29,7 +29,7 @@ import kieker.gui.subview.util.IModel;
import org.eclipse.swt.events.SelectionEvent; import org.eclipse.swt.events.SelectionEvent;
import org.eclipse.swt.events.SelectionListener; import org.eclipse.swt.events.SelectionListener;
public class Controller implements ISubController, SelectionListener { public final class Controller implements ISubController, SelectionListener {
private final ISubView view; private final ISubView view;
private final Model model; private final Model model;
......
...@@ -365,10 +365,10 @@ public final class View implements Observer, ISubView { ...@@ -365,10 +365,10 @@ public final class View implements Observer, ISubView {
final String totalDuration = (Long.toString(executionEntry.getTotalDuration()) + " " + View.this.model.getShortTimeUnit()).trim(); final String totalDuration = (Long.toString(executionEntry.getTotalDuration()) + " " + View.this.model.getShortTimeUnit()).trim();
if (parent != null) { if (parent != null) {
item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, "", minDuration, avgDuration, maxDuration, totalDuration }); item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, "", minDuration, avgDuration, maxDuration, totalDuration, });
} else { } else {
item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, Integer.toString(executionEntry.getCalls()), minDuration, avgDuration, item.setText(new String[] { executionEntry.getContainer(), componentName, operationString, Integer.toString(executionEntry.getCalls()), minDuration, avgDuration,
maxDuration, totalDuration }); maxDuration, totalDuration, });
} }
if (executionEntry.isFailed()) { if (executionEntry.isFailed()) {
......
...@@ -25,11 +25,11 @@ public abstract class AbstractDirectedComparator<T> implements Comparator<T>, Se ...@@ -25,11 +25,11 @@ public abstract class AbstractDirectedComparator<T> implements Comparator<T>, Se
private int direction; private int direction;
public int getDirection() { public final int getDirection() {
return this.direction; return this.direction;
} }
public void setDirection(final int direction) { public final void setDirection(final int direction) {
this.direction = direction; this.direction = direction;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment